Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cdk to 2.129.0 #13757

Merged
merged 4 commits into from
Jun 26, 2024
Merged

chore: upgrade cdk to 2.129.0 #13757

merged 4 commits into from
Jun 26, 2024

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented May 2, 2024

Description of changes

Upgrading the CDK library version to 2.129.0 which vends the upgraded Node 18 runtimes for the Lambda functions. This is necessary because:

We are ending support for Node.js 16 in Lambda on June 12, 2024. This follows Node.js 16 End-Of-Life (EOL) reached on September 11, 2023 [1]

This version is chosen so to be the target based on our testing and ease to upgrade without running into any complex breaking changes.

Notable changes:

  • Had to update the AWS SDK dependency in the custom pipeline awaiter.
  • Had to bump the package size which I believe is a natural increase because of the CDK library.

Issue #, if available

Description of how you validated changes

  • We first upgraded the CDK dependency in the API plugin repository and published a tag acdk-upgrade-2-129. Link to branch
  • We've upgraded the CDK dependency in CLI repo in the guest/data/upgrade-cdk-2.129.0 feature branch.
  • We've created a tagged-release-without-e2e-tests/acdk-upgrade-2-129 branch in CLI that consumes the upgraded API plugin via acdk-upgrade-2-129 tag and then published a CLI tag also with the same name.
  • We've run full E2E on tagged-release-without-e2e-tests/acdk-upgrade-2-129 branch in CLI. Link to run
  • We've then consumed the acdk-upgrade-2-129 tag of upgraded CLI in API repo and run full E2E suite there. Link to run.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar force-pushed the guest/data/upgrade-cdk-2.129.0 branch from c69541f to 77d6555 Compare June 25, 2024 02:04
@phani-srikar phani-srikar marked this pull request as ready for review June 25, 2024 16:18
@phani-srikar phani-srikar requested a review from a team as a code owner June 25, 2024 16:18
@awsluja
Copy link
Contributor

awsluja commented Jun 25, 2024

Looks like this modifies the codebuild files, I have manually started the PR-testing workflow, we should be able to proceed after that is passing.

@rtpascual rtpascual merged commit bd1ab65 into dev Jun 26, 2024
6 checks passed
@rtpascual rtpascual deleted the guest/data/upgrade-cdk-2.129.0 branch June 26, 2024 17:43
@dpilch dpilch mentioned this pull request Aug 1, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants