chore: log source version in e2e build log #13735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 24, 2024 13:11
0618
commented
Apr 25, 2024
| @@ -11,12 +11,17 @@ phases: | |||
| - cd .. | |||
| - source ./shared-scripts.sh && _downloadReportsFromS3 $CODEBUILD_SOURCE_VERSION | |||
| - mkdir artifacts && echo "empty artifact" > artifacts/empty-artifact.txt | |||
| post_build: | |||
| commands: | |||
| - echo $PROJECT_NAME | |||
There was a problem hiding this comment.
I had to write the repetitive code because after I used shared_script.sh in f0a4fcc, some builds couldn't find the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several ways to trigger e2e tests:
In order to know the status of the repo, we need to be notified timely when e2e test fails after a merge. So, we need to have a way to differentiate 3) from 1) and 2).
This PR is to add echos to log some infomation so that we'll be able to know in the builds log:
We the 2 info above, Cloudwatch is able to filter the datapoints and create a new metric so that we can set alarm from the metric.
Description of changes
Log
CODEBUILD_WEBHOOK_TRIGGERandCODEBUILD_BUILD_SUCCEEDINGin very e2e test build log.Issue #, if available
Description of how you validated changes
Verified in CodeBuild and created a metric using the data.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.