fix(amplify-cli-core): gracefully handle execa race condition #13692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When
execa
handles a hooks file that executes very fast, we have a race condition whereexeca
will try to pipe inputs to the child process'sstdin
after the process finishes causing anEPIPE
error (Refer to sindresorhus/execa#474).The change is to not have
execa
reject initially so we can determine what to do:Also updated how we pipe
stdout
for the child process, this caused the misconception that the hooks file was not running at all (noecho
in the hooks file is presented).Issue #, if available
Description of how you validated changes
Added unit tests and manually tested with the following pre-push and post-push hooks files:
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.