Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modern yarn install production command fails #13544

Conversation

WataruNishimura
Copy link

@WataruNishimura WataruNishimura commented Jan 19, 2024

First of all, I am Japanese so my English may be incorrect.

Description of changes

I have fixed the issue below.
#13377

This issue is caused by install command without devDependencies changes after major version 2 in yarn.

Specifically, yarn install --production changed deprecated and yarn workspaces focus --all --production is recommended.
This is described by below Yarn official website.
https://yarnpkg.com/cli/workspaces/focus

The new command also needs @yarnpkg/plugin-workspace-tools.
I wrote the code confirm the plugin is installed and works.

Issue #, if available

#13377

Description of how you validated changes

I wrote the test that checks workspace plugin is installed as unit test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WataruNishimura WataruNishimura requested a review from a team as a code owner January 19, 2024 12:59
@WataruNishimura WataruNishimura changed the title Fix yarn production install command for yarn 2 or after fix: modern yarn install production command fails Feb 13, 2024
@0618 0618 added the run-e2e label Mar 15, 2024
@WataruNishimura WataruNishimura marked this pull request as draft March 26, 2024 08:15
@WataruNishimura WataruNishimura marked this pull request as ready for review March 26, 2024 08:15
@WataruNishimura
Copy link
Author

WataruNishimura commented Mar 26, 2024

@0618
Excuse me, whould you teach me what "run-e2e" label means?
This is my first pull request in this repo.
Is therer anything to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants