Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update e2e coverage for policy update on auth removal #13538

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

edwardfoyle
Copy link
Contributor

@edwardfoyle edwardfoyle commented Jan 16, 2024

Description of changes

Follow up to #13523 to add e2e coverage.

Issue #, if available

Description of how you validated changes

e2e tests are running now https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing%3Afb316f43-c324-4d54-8f97-b4d0d61db404?region=us-east-1

There are a couple failures that seem like flakes but the updated test is passing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner January 16, 2024 21:32
@edwardfoyle edwardfoyle merged commit 97b1530 into aws-amplify:dev Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants