Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: assign region at runtime in e2e tests #13513

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Jan 3, 2024

Description of changes

This PR's goal is to remove as much of CLI_REGION assignment from generated e2e workflow as possible to free up space (cb yml files have hard size limit).
Therefore:

  1. Split e2e test script does not assign region unless test is force-pinned to some region.
  2. Adds a script that assigns region at runtime using job identifier.

Issue #, if available

Description of how you validated changes

E2E test run

From handful of jobs:

image

image

image

image

image

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk marked this pull request as ready for review January 3, 2024 20:30
@sobolk sobolk requested a review from a team as a code owner January 3, 2024 20:30
edwardfoyle
edwardfoyle previously approved these changes Jan 3, 2024
edwardfoyle
edwardfoyle previously approved these changes Jan 3, 2024
awsluja
awsluja previously approved these changes Jan 3, 2024
@sobolk sobolk dismissed stale reviews from awsluja and edwardfoyle via 44c1f6f January 3, 2024 23:34
@sobolk
Copy link
Member Author

sobolk commented Jan 4, 2024

finally
image

@sobolk sobolk merged commit 3c956a0 into aws-amplify:dev Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants