Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add credential refresh to long-running test #13441

Merged
merged 2 commits into from
Nov 30, 2023
Merged

test: add credential refresh to long-running test #13441

merged 2 commits into from
Nov 30, 2023

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Nov 30, 2023

Description of changes

This PR:

  1. adds credential refresh to auth migration test (it sometimes hits token expiry)
  2. removes deprecated --aea option from scripts

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner November 30, 2023 15:32
@sobolk sobolk merged commit 74f7698 into aws-amplify:dev Nov 30, 2023
4 checks passed
@sobolk sobolk deleted the improve-that-test branch November 30, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombguy bombguy bombguy approved these changes

@edwardfoyle edwardfoyle edwardfoyle approved these changes

@rtpascual rtpascual rtpascual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolk @bombguy @edwardfoyle @rtpascual