fix: keeps hooks intact when attaching backend #11179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Oct 13, 2022
Codecov Report
@@ Coverage Diff @@
## dev #11179 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 682 682
Lines 32861 32861
Branches 6708 6708
=======================================
+ Hits 16263 16264 +1
+ Misses 15118 15117 -1
Partials 1480 1480
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akshbhu
commented
Oct 13, 2022
sobolk
previously approved these changes
Oct 13, 2022
pavellazar
previously approved these changes
Oct 13, 2022
edwardfoyle
reviewed
Oct 14, 2022
|
Waiting for this PR to be merged. I hope it will fix this: #11021 |
5 tasks
akshbhu
force-pushed
the
fix/hooks_deletetion
branch
from
8e81b40 to
5c3d6be
Compare
aws-eddy
reviewed
Oct 19, 2022
aws-eddy
suggested changes
Oct 19, 2022
aws-eddy
previously approved these changes
Oct 19, 2022
sobolk
previously approved these changes
Oct 19, 2022
aws-eddy
reviewed
Oct 19, 2022
sobolk
approved these changes
Oct 19, 2022
aws-eddy
approved these changes
Oct 19, 2022
|
@akshbhu any idea when this fixed will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
amplify pull --envName devFix here is to keeps the hooks back into amplify folder when attaching backend.
Issue #11050
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.