fix: fallback to tpi when looking for existing envs on init #11137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshbhu
previously approved these changes
Oct 7, 2022
jhockett
previously approved these changes
Oct 7, 2022
jhockett
previously approved these changes
Oct 7, 2022
akshbhu
previously approved these changes
Oct 7, 2022
Co-authored-by: John Hockett <[email protected]>
jhockett
approved these changes
Oct 7, 2022
akshbhu
approved these changes
Oct 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit reverts a part of #10679
As part of that change, we no longer checked the contents of the team-provider-info file to determine if an environment already exists when doing an
amplify init. This caused some issues for customers using init to attach existing environments to their local projects. We now fall back to checking the contents of theteam-provider-info.jsonfile for existing environments on init.Issue #, if available
#11120
Description of how you validated changes
Manually tested, added unit tests and running the e2e tests here: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/11461/workflows/049075f2-67e0-4327-bbe3-b6067b8160ea
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.