-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: raise incorrect post event data #10954
fix: raise incorrect post event data #10954
Conversation
Hey @fossamagna - Thanks for the contribution! I see the function names were changed to match, but what is the context here? Was it breaking anything and was this intentional? Are there any tests we can add to ensure this works? Going to run the CLI test suite now. |
@danielleadams Thank you for your review. |
b4cf40f
to
a603926
Compare
Codecov Report
@@ Coverage Diff @@
## dev #10954 +/- ##
==========================================
+ Coverage 47.82% 48.12% +0.29%
==========================================
Files 669 669
Lines 32678 32678
Branches 6608 6608
==========================================
+ Hits 15627 15725 +98
+ Misses 15419 15329 -90
+ Partials 1632 1624 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@danielleadams I added test for |
Not sure if this issue is related, but I'll leave it here: #11021 |
Description of changes
Using an
AmplifyPostPushEventData
instance when raised aPostInit
event, and anAmplifyPostPushEventData
instance when raised aInitEvent
event. These use the wrong event data for each other.Fixed to use the correct event data.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.