chore(amplify-graphiql-explorer): upgrade react-scripts #10228
Conversation
johnpc
requested review from
a team,
marcvberg,
phani-srikar,
sundersc and
alharris-at
as code owners
johnpc
force-pushed
the
run-e2e/xss/upgrade-cra
branch
3 times, most recently
from
660586f to
071e13a
Compare
| @@ -0,0 +1,74 @@ | |||
| const fs = require("fs"); | |||
| const path = require("path"); | |||
| const nodeModulesPath = path.resolve(`${process.cwd()}/../..`, "node_modules"); | |||
There was a problem hiding this comment.
Builds were failing because of an incompatibility with semantic-ui and webpack5. A patch package was created to bridge the issue (Semantic-Org/Semantic-UI#7073 (comment)).
This script is a lightly modified version of that patch package modified to work with our lerna setup.
| @@ -0,0 +1,104 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Almost all the changes in this PR come from running CRA's eject script, which is necessary to add the polyfills needed in this package.
| modules: ['node_modules', paths.appNodeModules].concat( | ||
| modules.additionalModulePaths || [] | ||
| ), | ||
| fallback: { |
There was a problem hiding this comment.
These fallbacks I added to this generated file to support stream, util, crypto and buffer required by the jsonwebtoken dependency in this package.
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| /* Strict Type-Checking Options */ | |||
| "strict": true /* Enable all strict type-checking options. */, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
typescript was having some problems digesting the fact that @types/eslint and @types/eslint-scope are both in the dependency tree of this package.
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| yarn-path ".yarn/releases/yarn-1.18.0.cjs" |
There was a problem hiding this comment.
this silenced an error I was seeing when adding dependencies to this package
error An unexpected error occurred: "expected workspace package to exist for \"@babel/template\"".
Resolved by running yarn policies set-version 1.18 which generated these files. See yarnpkg/yarn#7807 for more
johnpc
changed the title
johnpc
force-pushed
the
run-e2e/xss/upgrade-cra
branch
5 times, most recently
from
6a37036 to
faab692
Compare
johnpc
force-pushed
the
run-e2e/xss/upgrade-cra
branch
from
faab692 to
6bf5744
Compare
There was a problem hiding this comment.
LGTM - changes are all localized to graphiql-explorer
Since this is GraphiQL related, it would be good to test this manually after clearing all local state.
( create-app + use graphiql + push + pull with amplify-tagged-release/dev + graphiql ).
we must test the same with datastore.
This PR updates react-scripts in amplify-graphiql-explorer.
This required:
yarn policies set-version 1.18to allow appropriate lerna dependency behaviorjsonwebtokendependencysemantic-uidependency at build time to work properly with webpack5"skipLibCheck": truein our tsconfig setup to prevent builds from failing due to the new dependencies