-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): reset api config on mock exit #9385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9385 +/- ##
==========================================
+ Coverage 55.36% 55.46% +0.10%
==========================================
Files 887 888 +1
Lines 50331 50384 +53
Branches 10869 10894 +25
==========================================
+ Hits 27866 27948 +82
+ Misses 20393 20370 -23
+ Partials 2072 2066 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the tests pass. Speaking of tests, is it possible to add a regression test?
👋 Hi, this pull request was referenced in the v7.6.6 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.6. |
👋 Hi, this pull request was referenced in the v7.6.7 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.7. |
In amplify --version = 12.10.3 - this is happening again. The amplify configuration.json and was-exports.js files continually add back in the "aws_appsync_dangerously_connect_to_http_endpoint_for_testing": true, |
Description of changes
Reset Amplify meta and aws-exports.js file on mock exit.
Issue #, if available
#9338
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.