ci: use amplify windows worker for smoke tests (#13188)

* ci: use amplify windows worker for smoke tests

* ci: add this

* ci: try this

* ci: try this

* Revert "ci: try this"

This reverts commit dbb7c14.

* chore: revert

* ci: try this

* Revert "ci: try this"

This reverts commit 7019317.

* chore: try this

* chore: try this

* chore: try this

* chore: try this too

* ci: delete windows custom

* chore: try this

* Revert "chore: try this"

This reverts commit 8328fa6.

* chore: try this

* chore: comments

.github/actions/install-cli/action.yml

@@ -21,6 +21,9 @@ runs:
       if: runner.os == 'Windows'
       run: |
         npm install -g @aws-amplify/cli@${{ inputs.cli-version }}
-        $AMPLIFY_PATH=(Get-Command amplify).Path
+        # "where.exe" is used instead of "where" to disambiguate
+        # "where" is aliased to "Where-Object" in powershell, i.e. not pointing to the tool we want
+        # "amplify.cmd" is searched because "where.exe amplify" returns ambiguous list
+        $AMPLIFY_PATH=(where.exe amplify.cmd)
         echo "AMPLIFY_PATH=$AMPLIFY_PATH"
         "AMPLIFY_PATH=$AMPLIFY_PATH" >> $env:GITHUB_ENV

.github/actions/run-smoke-tests/action.yml

@@ -21,6 +21,14 @@ runs:
         echo "AMPLIFY_PATH=$AMPLIFY_PATH"
         $AMPLIFY_PATH version
 
+    - name: Remove Pkg Fetch Checksum on Windows
+      shell: bash
+      if: runner.os == 'Windows'
+      run: |
+        cd scripts
+        yarn
+        yarn ts-node remove-pkg-fetch-checksum.ts
+
     - name: Install Dependencies
       shell: bash
       run: yarn install --immutable

.github/workflows/smoke-tests-manual.yml

@@ -11,7 +11,7 @@ on:
       os:
         required: false
         type: string
-        default: '["macos-latest-xl", "ubuntu-latest", "windows-latest"]'
+        default: '["macos-latest-xl", "ubuntu-latest", "amplify-cli_windows-latest_8-core"]'
       versions:
         required: false
         type: string

.github/workflows/smoke-tests.yml

@@ -11,7 +11,7 @@ on:
       os:
         required: false
         type: string
-        default: '["macos-latest-xl", "ubuntu-latest", "windows-latest"]'
+        default: '["macos-latest-xl", "ubuntu-latest", "amplify-cli_windows-latest_8-core"]'
       versions:
         required: false
         type: string
@@ -40,14 +40,7 @@ jobs:
         with:
           cli-version: ${{ matrix.cli-version }}
 
-      - name: Run Smoke Tests Unix
-        if: runner.os != 'Windows'
+      - name: Run Smoke Tests
         uses: ./.github/actions/run-smoke-tests
         with:
           role-to-assume: ${{ secrets.SMOKE_TESTS_ROLE_ARN }}
-
-      - name: Run Smoke Tests Windows
-        if: runner.os == 'Windows'
-        uses: ./.github/actions/run-smoke-tests-windows
-        with:
-          role-to-assume: ${{ secrets.SMOKE_TESTS_ROLE_ARN }}

packages/amplify-e2e-core/src/utils/nexpect.ts

@@ -737,7 +737,7 @@ export function nspawn(command: string | string[], params: string[] = [], option
   }
 
   const testingWithLatestCodebase = isTestingWithLatestCodebase(command);
-  if (testingWithLatestCodebase || (process.platform === 'win32' && !command.endsWith('.exe'))) {
+  if (testingWithLatestCodebase || (process.platform === 'win32' && !(command.endsWith('.exe') || command.endsWith('.cmd')))) {
     params.unshift(command);
     command = getScriptRunnerPath(testingWithLatestCodebase);
   }