Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codeowners on deviation_estimation_tools #58

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Jun 19, 2024

Description

There is no codeowner of deviation_estimation_tools in TIER IV Localization & Mapping team. So I would like to add some members to it.

Related links

Nothing

Tests performed

Nothing

Notes for reviewers

Nothing

Interface changes

Nothing

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Motsu-san Motsu-san enabled auto-merge (squash) June 19, 2024 12:49
@Motsu-san Motsu-san requested a review from mitsudome-r June 19, 2024 13:10
@Motsu-san Motsu-san changed the title chore(CODEOWNERS): Update CODEOWNERS on deviation_estimation_tools chore(codeowners): Update codeowners on deviation_estimation_tools Jun 19, 2024
@Motsu-san Motsu-san changed the title chore(codeowners): Update codeowners on deviation_estimation_tools chore: Update codeowners on deviation_estimation_tools Jun 19, 2024
@Motsu-san Motsu-san changed the title chore: Update codeowners on deviation_estimation_tools chore: update codeowners on deviation_estimation_tools Jun 19, 2024
@Motsu-san
Copy link
Contributor Author

@mitsudome-r Could you review this pull-request?

@mitsudome-r
Copy link
Member

@Motsu-san Thank you for the PR.

The CODEOWNERS are updated automatically from package.xml information. Could you add them to the maintainers in the package.xml instead of modifying CODEOWNERS directly?
https://github.com/autowarefoundation/autoware_tools/blob/main/localization/deviation_estimation_tools/deviation_estimator/package.xml

@Motsu-san Motsu-san force-pushed the chore/add_codeowners_to_deviation_estimation_tools branch from 67e9c30 to 0f48224 Compare June 20, 2024 06:09
@Motsu-san Motsu-san requested a review from kminoda as a code owner June 20, 2024 06:09
@Motsu-san
Copy link
Contributor Author

@kminoda Could you review this pull-request?

@Motsu-san
Copy link
Contributor Author

@mitsudome-r Thank you for your review. I modified the package.xml files.

to deviation_estimation_tools
:wrench:

Signed-off-by: Motsu-san <[email protected]>
@Motsu-san Motsu-san force-pushed the chore/add_codeowners_to_deviation_estimation_tools branch from 0f48224 to ea4ed97 Compare June 20, 2024 06:12
@Motsu-san Motsu-san merged commit d27cfe1 into autowarefoundation:main Jun 20, 2024
16 checks passed
@Motsu-san Motsu-san deleted the chore/add_codeowners_to_deviation_estimation_tools branch June 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants