-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add analyze_rosbags_parallel.py
#217
Merged
SakodaShintaro
merged 18 commits into
autowarefoundation:main
from
SakodaShintaro:feat/add_analyze_rosbags_parallel
Feb 28, 2025
Merged
feat: add analyze_rosbags_parallel.py
#217
SakodaShintaro
merged 18 commits into
autowarefoundation:main
from
SakodaShintaro:feat/add_analyze_rosbags_parallel
Feb 28, 2025
+124
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Shintaro Sakoda <[email protected]>
analyze_rosbags_parallel.sh
analyze_rosbags_parallel.py
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
commented
Feb 27, 2025
localization/autoware_localization_evaluation_scripts/scripts/compare_trajectories.py
Show resolved
Hide resolved
hayato-m126
reviewed
Feb 28, 2025
localization/autoware_localization_evaluation_scripts/scripts/analyze_rosbags_parallel.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
hayato-m126
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new script
analyze_rosbags_parallel.py
and refactors code for usability.How was this PR tested?
(1) Perform DLRv2 many times.
ros2 launch driving_log_replayer_v2 driving_log_replayer_v2.launch.py \ scenario_path:=$HOME/driving_log_replayer_v2/localization.yaml
Results
(2) Perform
analyze_rosbags_parallel.py
ros2 run autoware_localization_evaluation_scripts analyze_rosbags_parallel.py \ $HOME/driving_log_replayer_v2/out \ --parallel_num=4
Notes for reviewers
None.
Effects on system behavior
None.