-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): remove latest tag #5201
fix(docker): remove latest tag #5201
Conversation
3e95642
to
54f5639
Compare
@youtalk please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the docker-build-and-push
CI to check the validity.
54f5639
to
fb8402f
Compare
@youtalk could you review it again |
Because you didn't run the workflow, I did it. I will review again when it is done. |
Signed-off-by: Oguz Ozturk <[email protected]>
fb8402f
to
d512c9d
Compare
I checked the logs within this run and there were no images exported with Anyway I just started a new workflow run to double-check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your double check. LGTM
@oguzkaganozt By the way, I started to feel that the Here’s the final image I have in mind:
|
@youtalk I agree that we should omit the |
Description
Removal of
latest
tag from images, instead use it as a stable tag touniverse
Fixes #5175
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.