fix(.dockerignore): not ignore specific csv and png files
#5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
youtalk
added
DevOps Dojo: Build & Run
type:containers
youtalk
changed the title
csv and png files
oguzkaganozt
approved these changes
Sep 6, 2024
|
@oguzkaganozt Please see my comment #5009 (comment). I hope most of them are for test case. |
|
Hello @youtalk i'm not sure if it's worked i tried universe-cuda-20240919 but the files that won't be ignored are still ignored. |
|
@yvzksgl Please provide the list which you want not to ignore. |
|
PNG files in src/universe/autoware.universe/common/autoware_overlay_rviz_plugin/autoware_overlay_rviz_plugin/assets and CSV files in src/universe/autoware.universe/vehicle/autoware_raw_vehicle_cmd_converter/data/default |
|
I've comfirmed the latest image doesn't have the files. I reopen the issue #5180. docker run --rm -it ghcr.io/autowarefoundation/autoware:universe-devel-cuda
ls /opt/autoware/share/autoware_overlay_rviz_plugin/assets/images/
ls /opt/autoware/share/autoware_raw_vehicle_cmd_converter/data/default/ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #5180
Resolved #5084
This PR does not ignore specific files to copy to Docker images.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.