chore(clang-tidy): remove deprecated/unsupported AnalyzeTemporaryDtors setting

[mojomex]

Description

This PR aims to make Clang-Tidy usable in IDEs, e.g. with Clangd as a language server. For VS Code, the default Clangd version is 18, which does not support the AnalyzeTemporaryDtors option anymore, which was deprecated in version 16.

This PR removes the setting which, according to the Clang 16 release notes is no longer in use:

Deprecate the global configuration file option AnalyzeTemporaryDtors, which is no longer in use. The option will be fully removed in clang-tidy version 18.

Related links:

• LLVM GitHub: Discussion about removal of the option
• Clang 16 Release Notes: Deprecation message

Tests performed

Before the change, Clangd 18 would show errors when parsing .clang-tidy:

E[10:48:30.356] tidy-config error at /home/.../autoware/.clang-tidy:205:0: unknown key 'AnalyzeTemporaryDtors'
E[10:48:30.356] Error parsing clang-tidy configuration in /home/.../autoware/.clang-tidy: Invalid argument

After the change, the errors are gone.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[mitsudome-r]

NOTE:
The default clang-tidy version in Ubuntu 22.04 is 14, but the default config for AnalyzeTemporaryDtors seems to be false so this modification shouldn't have impact on environments with older versions of clang-tidy as well.