Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-build-and-push should not push an image for every commit to main #4878

Closed
xmfcx opened this issue Jun 17, 2024 · 0 comments
Closed

docker-build-and-push should not push an image for every commit to main #4878

xmfcx opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration.

Comments

@xmfcx
Copy link
Contributor

xmfcx commented Jun 17, 2024

Before this PR, docker-build-and-push was being triggered only on schedule.

After this change, and still, this action is running and pushing (There are almost daily images published.) per PR.

Was this expected behavior? Do we want the images to be updated this often?

image

@oguzkaganozt @youtalk

Originally posted by @xmfcx in #4072 (comment)

Resolution

The commits to main should not trigger the this push image action.

Not every change in main branch justifies creation of a new image. (e.g. documentation changes, unrelated CI changes).

And most of the relevant changes happen in the Autoware Universe repo anyways.

If we need to push a new image (and cannot wait for 1st or 15th day of the month), the tag system can be used.

Being solved by:

@xmfcx xmfcx added type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration. labels Jun 17, 2024
@xmfcx xmfcx changed the title Right now docker-build-and-push is running per PR docker-build-and-push should not for every commit to main Jun 18, 2024
@xmfcx xmfcx changed the title docker-build-and-push should not for every commit to main docker-build-and-push should not push an image for every commit to main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

No branches or pull requests

3 participants