docker-build-and-push-main is failing

[xmfcx]

docker-build-and-push-main CI started failing after this was merged:

• https://github.com/autowarefoundation/autoware/actions/runs/9516216183

ERROR: tag is needed when pushing to registry
Error: buildx bake failed with: ERROR: tag is needed when pushing to registry

https://github.com/autowarefoundation/autoware/actions/runs/9516216183/job/26232045461#step:8:1288

@oguzkaganozt

Probabable cause

It has passed the test on the initial PR description:

• https://github.com/autowarefoundation/autoware/actions/runs/9450305663

Then, some tag related things were changed within the PR review process:
#4849 (comment)

To prevent such cases from happening, perform the tests again before merging.

Originally posted by @xmfcx in #4849 (comment)

[xmfcx]

@youtalk @oguzkaganozt @mitsudome-r I'll now start working on this task.

[xmfcx]

The test on the PR description passed:

• https://github.com/autowarefoundation/autoware/actions/runs/9450305663/job/26028579890#step:5:735

But the workflow triggered by the commit pushed failed:

• https://github.com/autowarefoundation/autoware/actions/runs/9516216183/job/26232045461#step:8:715

They use docker-build-and-push/action.yaml action.

The biggest difference I see between them is,

• workflow_dispatch triggered workflow that has passed, allow-push=false
• push to main triggered workflow that has passed, allow-push=true

Trigger	allow-push	Workflow Status
workflow_dispatch	false	✅
push to main	true	❌

So the test doesn't cover the allow-push=true case.

I will investigate further.

[xmfcx]

https://github.com/autowarefoundation/autoware/actions/runs/9577390080

Still failing.

[xmfcx]

• docker-build-and-push should not push an image for every commit to main #4878

Since we no longer trigger this by the push event, it shouldn't be an issue anymore.