chore: rename codeowners file #9657
Closed
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Dec 16, 2024 in 2m 39s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.00 (6.53 -> 6.53)
- Declining Code Health: 61 findings(s) 🚩
- Improving Code Health: 75 findings(s) ✅
- Affected Hotspots: 11 files(s) 🔥
View detailed results in CodeScene
Absence of Expected Change Pattern
- autoware.universe/planning/autoware_velocity_smoother/src/smoother/jerk_filtered_smoother.cpp is usually changed with: autoware.universe/planning/autoware_velocity_smoother/src/smoother/linf_pseudo_jerk_smoother.cpp
- autoware.universe/control/autoware_pid_longitudinal_controller/src/longitudinal_controller_utils.cpp is usually changed with: autoware.universe/control/autoware_pid_longitudinal_controller/test/test_longitudinal_controller_utils.cpp
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method pid_longitudinal_controller.cpp: PidLongitudinalController::updateControlState
- Complex Method manager.cpp: LaneChangeModuleManager::set_params
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::onFreespaceParkingTimer 🔥
- Large Method plot_map.cpp: main
- Complex Method node.cpp: AEB::checkCollision 🔥
- Complex Conditional scene.cpp: NormalLaneChange::filterObjectsByLanelets 🔥
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::selectPullOverPath 🔥
- Complex Conditional plot_map.cpp: selectPullOverPaths
- Complex Method plot_map.cpp: selectPullOverPaths
- Complex Method scene.cpp: BlindSpotModule::generateBlindSpotLanelets
- Complex Method scene.cpp: DetectionAreaModule::modifyPathVelocity
- Code Duplication test_managed_transform_buffer.cpp
- Code Duplication lanelet_filter.cpp
- Overall Code Complexity lanelet_filter.cpp
- Overall Code Complexity plot_map.cpp
- Deep, Nested Complexity scene.cpp: NormalLaneChange::filterObjectsByLanelets 🔥
- Overall Code Complexity scene.cpp
- Complex Method scene_occlusion_spot.cpp: OcclusionSpotModule::modifyPathVelocity
- Complex Method scene_no_stopping_area.cpp: NoStoppingAreaModule::modifyPathVelocity
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Complex Method scene.cpp: StopLineModule::modifyPathVelocity
- Complex Method mission_planner.cpp: MissionPlanner::on_set_lanelet_route
- Complex Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::run 🔥
- Complex Method scene.cpp: NormalLaneChange::filterObjectsByLanelets 🔥
- Complex Method node.cpp: SurroundObstacleCheckerNode::onTimer
- Large Method scene.cpp: StaticObstacleAvoidanceModule::fillFundamentalData 🔥
- Complex Method mission_planner.cpp: MissionPlanner::on_set_waypoint_route
- Complex Method utils.cpp: filterTargetObjects 🔥
- Complex Method scene_merge_from_private_road.cpp: MergeFromPrivateRoadModule::modifyPathVelocity
- Complex Method scene.cpp: TrafficLightModule::modifyPathVelocity
- Large Method control_performance_analysis_core.cpp: ControlPerformanceAnalysisCore::calculateDrivingVars
- Large Method test_utilization.cpp: TEST:specialInterpolation:specialInterpolation
- Complex Method mrm_summary_overlay_display.cpp: MrmSummaryOverlayDisplay::update
- Complex Method scene_crosswalk.cpp: CrosswalkModule::calcStopPose 🔥
- Large Method acceleration_meter.cpp: AccelerationMeterDisplay::update
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::selectPullOverPath 🔥
- Complex Method utils.cpp: isEgoOutOfRoute 🔥
- Complex Method utils.cpp: isParkedVehicle 🔥
- Complex Method scene.cpp: RunOutModule::modifyPathVelocity
- Complex Method node.cpp: AEB::getClosestObjectsOnPath 🔥
- Complex Method utils.cpp: getLeadingStaticObjectIdx 🔥
- Excess Number of Function Arguments test_managed_transform_buffer.cpp: generateTransformMsg
- Duplicated Assertion Blocks test_managed_transform_buffer.cpp: TEST:TestManagedTransformBuffer:TestTransformMultipleCall
- Excess Number of Function Arguments plot_map.cpp: selectPullOverPaths
- Complex Conditional scene_crosswalk.cpp: CrosswalkModule::calcStopPose 🔥
- Complex Method scene_module_interface.cpp: SceneModuleManagerInterface::modifyPathVelocity
- Complex Method manager.cpp: TrafficLightModuleManager::modifyPathVelocity
- Complex Method scene.cpp: findLaneIdInterval
- Complex Method utils.cpp: passed_parked_objects 🔥
- Complex Method utils.cpp: isParkedObject 🔥
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::onTimer 🔥
- Complex Conditional goal_planner_module.cpp: PathDecisionStateController::get_next_state 🔥
- Complex Conditional plot_map.cpp: hasEnoughDistance
- Bumpy Road Ahead mrm_summary_overlay_display.cpp: MrmSummaryOverlayDisplay::update
- Bumpy Road Ahead test_perception_online_evaluator_node.cpp: setTargetMetric
- Bumpy Road Ahead plot_map.cpp: selectPullOverPaths
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::isStopped 🔥
- Bumpy Road Ahead goal_planner_module.cpp: PathDecisionStateController::get_next_state 🔥
- Bumpy Road Ahead scene.cpp: NormalLaneChange::filterObjectsByLanelets 🔥
- Bumpy Road Ahead scene.cpp: BlindSpotModule::generateBlindSpotLanelets
- Bumpy Road Ahead scene.cpp: StopLineModule::modifyPathVelocity
✅ Improving Code Health:
- Complex Conditional mpc_lateral_controller.cpp: MpcLateralController::run
- Overall Code Complexity mpc.cpp
- Lines of Code in a Single File node.cpp
- Overall Function Size pid_based_planner.cpp
- Overall Code Complexity pid_based_planner.cpp
- Overall Code Complexity planner_interface.cpp
- Overall Code Complexity node.cpp
- Overall Code Complexity node.cpp
- Overall Code Complexity goal_planner_module.cpp 🔥
- Overall Code Complexity util.cpp
- Overall Code Complexity behavior_path_planner_node.cpp 🔥
- Lines of Code in a Single File static_drivable_area.cpp
- Overall Code Complexity static_drivable_area.cpp
- Overall Code Complexity path_utils.cpp
- Lines of Code in a Single File scene.cpp 🔥
- Overall Code Complexity scene.cpp 🔥
- Large Method manager.cpp: LaneChangeModuleManager::updateModuleParams
- Complex Method node.cpp: VelocitySmootherNode::calcExternalVelocityLimit
- Complex Method node.cpp: VelocitySmootherNode::smoothVelocity
- Complex Method scene.cpp: StaticObstacleAvoidanceModule::insertPrepareVelocity 🔥
- Complex Method safety_check.cpp: get_collided_polygons
- Complex Method goal_planner_module.cpp: GoalPlannerModule::updateData 🔥
- Large Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::BehaviorPathPlannerNode 🔥
- Complex Conditional simple_planning_simulator_core.cpp: SimplePlanningSimulator::set_initial_state
- Complex Method node.cpp: VelocitySmootherNode::calcInitialMotion
- Complex Method node.cpp: AEB::generateEgoPath 🔥
- Complex Conditional goal_planner_module.cpp: FreespaceParkingPlanner::onTimer 🔥
- Complex Conditional goal_planner_module.cpp: sortPullOverPaths 🔥
- Complex Method static_drivable_area.cpp: generateDrivableArea
- Complex Method goal_planner_module.cpp: GoalPlannerModule::planPullOverAsOutput 🔥
- Complex Method goal_planner_module.cpp: LaneParkingPlanner::onTimer 🔥
- Complex Method goal_planner_module.cpp: sortPullOverPaths 🔥
- Complex Method goal_planner_module.cpp: FreespaceParkingPlanner::onTimer 🔥
- Complex Method goal_planner_module.cpp: FreespaceParkingPlanner::isStuck 🔥
- Complex Method goal_planner_module.cpp: LaneParkingPlanner::LaneParkingPlanner 🔥
- Complex Conditional scene.cpp: NormalLaneChange::filter_objects 🔥
- Complex Method scene.cpp: NormalLaneChange::filter_objects 🔥
- Complex Method scene.cpp: StaticObstacleAvoidanceModule::fillFundamentalData 🔥
- Complex Method scene.cpp: NormalLaneChange::is_collided 🔥
- Primitive Obsession planner_interface.cpp
- Deep, Nested Complexity goal_planner_module.cpp: LaneParkingPlanner::onTimer 🔥
- Deep, Nested Complexity utils.cpp: filter_target_lane_objects 🔥
- Primitive Obsession scene_intersection.cpp 🔥
- Primitive Obsession util.cpp
- Complex Method static_drivable_area.cpp: cutOverlappedLanes
- Complex Method simple_planning_simulator_core.cpp: SimplePlanningSimulator::initialize_vehicle_model
- Complex Method utils.cpp: filter_target_lane_objects 🔥
- Complex Method utils.cpp: is_delay_lane_change 🔥
- Complex Method util.cpp: createDepartureCheckLanelet
- Complex Conditional utils.cpp: is_delay_lane_change 🔥
- Complex Conditional utils.cpp: filter_target_lane_objects 🔥
- Large Method test_safety_check.cpp: TEST:BehaviorPathPlanningSafetyUtilsTest:checkCollision
- Bumpy Road Ahead utils.cpp: filter_target_lane_objects 🔥
- Complex Method mpc_lateral_controller.cpp: MpcLateralController::run
- Complex Method simple_planning_simulator_core.cpp: SimplePlanningSimulator::set_initial_state
- Complex Conditional node.cpp: AEB::generateEgoPath 🔥
- Excess Number of Function Arguments mpc.cpp: MPC::calculateMPC
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::updateData 🔥
- Bumpy Road Ahead goal_planner_module.cpp: LaneParkingPlanner::onTimer 🔥
- Bumpy Road Ahead goal_planner_module.cpp: sortPullOverPaths 🔥
- Bumpy Road Ahead goal_planner_module.cpp: isStopped 🔥
- Bumpy Road Ahead goal_planner_module.cpp: FreespaceParkingPlanner::onTimer 🔥
- Bumpy Road Ahead safety_check.cpp: get_collided_polygons
- Excess Number of Function Arguments goal_planner_module.cpp: needPathUpdate 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: sortPullOverPaths 🔥
- Excess Number of Function Arguments utils.cpp: filter_target_lane_objects 🔥
- Excess Number of Function Arguments utils.cpp: calcDistanceToReturnDeadLine 🔥
- Complex Conditional pid_longitudinal_controller.cpp: PidLongitudinalController::updateControlState
- Complex Method controller_node.cpp: Controller::mergeLatLonHorizon
- Complex Method controller_node.cpp: Controller::Controller
- Bumpy Road Ahead controller_node.cpp: Controller::mergeLatLonHorizon
- Overall Code Complexity interface.cpp 🔥
- Excess Number of Function Arguments test_safety_check.cpp: create_rss_parameters
- Excess Number of Function Arguments test_safety_check.cpp: create_path_with_velocity_and_polygon
- Overall Code Complexity scene.cpp
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
SimplePlanningSimulator::initialize_vehicle_model decreases in cyclomatic complexity from 19 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
SimplePlanningSimulator::set_initial_state decreases in cyclomatic complexity from 14 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Conditional
SimplePlanningSimulator::set_initial_state decreases from 1 complex conditionals with 7 branches to 1 complex conditionals with 4 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 182 in common/tier4_vehicle_rviz_plugin/src/tools/acceleration_meter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
AccelerationMeterDisplay::update has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 579 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
AEB::checkCollision already has high cyclomatic complexity, and now it increases in Lines of Code from 130 to 133. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
AEB::generateEgoPath is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 950 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
AEB::getClosestObjectsOnPath has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 682 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
AEB::generateEgoPath no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 1 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.96 to 6.04, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in control/autoware_mpc_lateral_controller/src/mpc.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.16 to 5.11, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 127 in control/autoware_mpc_lateral_controller/src/mpc.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Excess Number of Function Arguments
MPC::calculateMPC decreases from 6 to 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 337 in control/autoware_mpc_lateral_controller/src/mpc_lateral_controller.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
MpcLateralController::run decreases in cyclomatic complexity from 17 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 282 in control/autoware_mpc_lateral_controller/src/mpc_lateral_controller.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
MpcLateralController::run no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PidLongitudinalController::updateControlState already has high cyclomatic complexity, and now it increases in Lines of Code from 137 to 139. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
PidLongitudinalController::updateControlState no longer has a complex conditional
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.59 to 4.65, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 256 in control/autoware_trajectory_follower_node/src/controller_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
Controller::mergeLatLonHorizon is no longer above the threshold for cyclomatic complexity
Check notice on line 76 in control/autoware_trajectory_follower_node/src/controller_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
Controller::Controller is no longer above the threshold for cyclomatic complexity
Check notice on line 256 in control/autoware_trajectory_follower_node/src/controller_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
Controller::mergeLatLonHorizon is no longer above the threshold for logical blocks with deeply nested code
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
ControlPerformanceAnalysisCore::calculateDrivingVars increases from 74 to 75 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
setTargetMetric has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/autoware_freespace_planning_algorithms/src/astar_search.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.74 to 4.91, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
MissionPlanner::on_set_lanelet_route increases in cyclomatic complexity from 28 to 30, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
MissionPlanner::on_set_waypoint_route increases in cyclomatic complexity from 24 to 26, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/autoware_mission_planner/src/mission_planner/mission_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.36 to 5.71, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading