fix(image_projection_based_fusion): segmentation pointcloud fusion param update #7858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
badai-nguyen
added
run:deploy-docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7858 +/- ##
==========================================
- Coverage 28.66% 28.65% -0.01%
==========================================
Files 1588 1589 +1
Lines 116375 116398 +23
Branches 49688 49693 +5
==========================================
Hits 33357 33357
- Misses 73907 73930 +23
Partials 9111 9111
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen
requested review from
kminoda,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
YoshiRi
reviewed
Jul 5, 2024
| filter_scope_max_y: 100.0 | ||
| filter_scope_min_z: -100.0 | ||
| filter_scope_max_z: 100.0 | ||
| # the maximum distance of pointcloud to be applied filter |
There was a problem hiding this comment.
I can not get what distance means until reading the code.
It means maximum z depth, so how about change its explanation?
Suggested change
| # the maximum distance of pointcloud to be applied filter | |
| # the maximum depth of pointcloud to be applied filter |
YoshiRi
approved these changes
Jul 5, 2024
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…ram update (autowarefoundation#7858) Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 1, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 5, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 26, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 2, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 2, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 2, 2024
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 10, 2024
….29.0 (#1526) * feat(tensorrt yolox): inference and publish mask image from yolox model with semantic segmentation header (autowarefoundation#5553) * add segmentation model Signed-off-by: badai-nguyen <[email protected]> fix: add multitask for segment Signed-off-by: badai-nguyen <[email protected]> * fix: publish mask Signed-off-by: badai-nguyen <[email protected]> * feat: publish colorized mask Signed-off-by: badai-nguyen <[email protected]> * fix: resize yolox mask Signed-off-by: badai-nguyen <[email protected]> * fix: add memory allocate operations Signed-off-by: Manato HIRABAYASHI <[email protected]> * refactor: remove underscore for a local variable Signed-off-by: Manato HIRABAYASHI <[email protected]> * chore: add condition to check the number of subscriber for newly added topics Signed-off-by: Manato HIRABAYASHI <[email protected]> * chore: pre-commit Signed-off-by: badai-nguyen <[email protected]> * fix: add roi overlapping segment Signed-off-by: badai-nguyen <[email protected]> * fix: roi overlay segment Signed-off-by: badai-nguyen <[email protected]> * chore: refactor Signed-off-by: badai-nguyen <[email protected]> * docs: update readme Signed-off-by: badai-nguyen <[email protected]> * fix: update model name Signed-off-by: badai-nguyen <[email protected]> * fix: add utils into tensorrt_yolox Signed-off-by: badai-nguyen <[email protected]> * fix: launch file Signed-off-by: badai-nguyen <[email protected]> * chore: remove unnecessary depend Signed-off-by: badai-nguyen <[email protected]> * chore: fix yaml file Signed-off-by: badai-nguyen <[email protected]> * chore: remove duplicated param in launch Signed-off-by: badai-nguyen <[email protected]> * fix: semantic class Signed-off-by: badai-nguyen <[email protected]> * docs: update readme Signed-off-by: badai-nguyen <[email protected]> * chore: update default param Signed-off-by: badai-nguyen <[email protected]> * fix: add processing time topic Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * chore: fix cspell error Signed-off-by: badai-nguyen <[email protected]> * fix: yolox default param Signed-off-by: badai-nguyen <[email protected]> * chore: rename debug topics Signed-off-by: badai-nguyen <[email protected]> * chore: rename debug topics Signed-off-by: badai-nguyen <[email protected]> * docs: update model description Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: launch Signed-off-by: badai-nguyen <[email protected]> * refactor: unpublish mask for single task Signed-off-by: badai-nguyen <[email protected]> * Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp Co-authored-by: Manato Hirabayashi <[email protected]> * Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp Co-authored-by: Manato Hirabayashi <[email protected]> * Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp Co-authored-by: Manato Hirabayashi <[email protected]> * style(pre-commit): autofix * docs: update reamde Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: skip mask size as yolox output Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Manato HIRABAYASHI <[email protected]> Co-authored-by: Manato HIRABAYASHI <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Manato Hirabayashi <[email protected]> * fix(tensorrt_yolox): add run length encoding for sematic segmentation mask (autowarefoundation#7905) * fix: add rle compress Signed-off-by: badai-nguyen <[email protected]> * fix: rle compress Signed-off-by: badai-nguyen <[email protected]> * fix: move rle into utils Signed-off-by: badai-nguyen <[email protected]> * chore: pre-commit Signed-off-by: badai-nguyen <[email protected]> * Update perception/autoware_tensorrt_yolox/src/utils.cpp Co-authored-by: Yukihiro Saito <[email protected]> * fix: remove unused variable Signed-off-by: badai-nguyen <[email protected]> * Update perception/autoware_tensorrt_yolox/src/utils.cpp Co-authored-by: Manato Hirabayashi <[email protected]> * style(pre-commit): autofix * feat: add unit test for utils Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: unit test Signed-off-by: badai-nguyen <[email protected]> * chore: change to explicit index Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: cuda cmake Signed-off-by: badai-nguyen <[email protected]> * fix: separate unit test into different PR Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Co-authored-by: Manato Hirabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(tensorrt_yolox): move utils into perception_utils (autowarefoundation#8435) * chore(tensorrt_yolo): refactor utils Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: tensorrt_yolox Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(perception_utils): install library after build (autowarefoundation#8501) Signed-off-by: Manato HIRABAYASHI <[email protected]> * fix(image_projection_based_fusion): resize sematic segmentation mask as input image size (autowarefoundation#7635) Signed-off-by: badai-nguyen <[email protected]> * fix(image_projection_based_fusion): segmentation pointcloud fusion param update (autowarefoundation#7858) * fix(image_projection_based_fusion): add run length decoding for segmentation_pointcloud_fusion (autowarefoundation#7909) * fix: add rle decompress Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix: use rld in tensorrt utils Signed-off-by: badai-nguyen <[email protected]> * fix: rebase error Signed-off-by: badai-nguyen <[email protected]> * fix: dependency Signed-off-by: badai-nguyen <[email protected]> * fix: skip publish debug mask Signed-off-by: badai-nguyen <[email protected]> * Update perception/autoware_image_projection_based_fusion/src/segmentation_pointcloud_fusion/node.cpp Co-authored-by: kminoda <[email protected]> * style(pre-commit): autofix * Revert "fix: skip publish debug mask" This reverts commit 30fa9ae. --------- Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <[email protected]> * feat(tier4_perception_launch): add image segmentation based pointcloud filter (autowarefoundation#7225) * feat(tier4_perception_launch): add image segmentation based pointcloud filter Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * fix: detection launch Signed-off-by: badai-nguyen <[email protected]> * chore: add maintainer Signed-off-by: badai-nguyen <[email protected]> * Revert "chore: add maintainer" This reverts commit 5adfef6. --------- Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * fix(autoware_image_projection_based_fusion): resolve issue with segmentation pointcloud fusion node failing with multiple mask inputs (autowarefoundation#8769) --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Manato HIRABAYASHI <[email protected]> Co-authored-by: Manato HIRABAYASHI <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Manato Hirabayashi <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.