Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(build-and-test-x): fix cache and merge clang-tidy #7723

Merged
merged 5 commits into from
Jun 27, 2024
Merged

ci(build-and-test-x): fix cache and merge clang-tidy #7723

merged 5 commits into from
Jun 27, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 27, 2024 •
edited
Loading

Description

  • Added steps to export CUDA state as a variable for cache key in multiple workflow files.
  • Updated build steps to include CUDA state in cache key.
  • Integrated clang-tidy differential job into the build-and-test-differential workflow, removing the need for a separate workflow file.

Changes walkthrough 📝

Relevant files
Enhancement
build-and-test-daily-arm64.yaml
Export CUDA state and update cache key in ARM64 workflow 

.github/workflows/build-and-test-daily-arm64.yaml

  • Added step to export CUDA state as a variable for cache key.
  • Updated build step to include CUDA state in cache key.
    		•  +11/-0   
    build-and-test-daily.yaml
    Export CUDA state and update cache key in daily workflow 

    .github/workflows/build-and-test-daily.yaml

  • Added step to export CUDA state as a variable for cache key.
  • Updated build step to include CUDA state in cache key.
    		•  +11/-0   
    build-and-test-differential-arm64.yaml
    Export CUDA state and update cache key in differential ARM64 workflow

    .github/workflows/build-and-test-differential-arm64.yaml

  • Added step to export CUDA state as a variable for cache key.
  • Updated build step to include CUDA state in cache key.
    		•  +11/-0   
    build-and-test-differential.yaml
    Export CUDA state and integrate clang-tidy in differential workflow

    .github/workflows/build-and-test-differential.yaml

  • Added step to export CUDA state as a variable for cache key.
  • Integrated clang-tidy differential job into the workflow.
    		•  +55/-0   
    build-and-test.yaml
    Export CUDA state and update cache key in build-and-test workflow

    .github/workflows/build-and-test.yaml

  • Added step to export CUDA state as a variable for cache key.
  • Updated build step to include CUDA state in cache key.
    		•  +11/-0   
    Configuration changes
    clang-tidy-differential.yaml
    Remove separate clang-tidy differential workflow file       

    .github/workflows/clang-tidy-differential.yaml

    • Removed the separate clang-tidy differential workflow file.
    		 +0/-55   

    Related links

    Parent Issue:

    Follow up from:

    How was this PR tested?

    Notes for reviewers

    ❌ Old broken caches:

    • cuda and nocuda separation is not made.
    • test part caches its own thing, doesn't use cache from build...

    image

    ✅ Caches with this PR:

    image

    • colcon-test does not use cache anymore since it is on the same machine
    • clang-tidy uses new (cuda, nocuda) separated caches

    Interface changes

    None.

    Effects on system behavior

    None.

    @xmfcx xmfcx self-assigned this Jun 27, 2024
    @xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 27, 2024
    @github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 27, 2024
    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Jun 27, 2024 •
    edited
    Loading

    Thank you for contributing to the Autoware project!

    🚧 If your pull request is in progress, switch it to draft mode.

    Please ensure:

    @xmfcx xmfcx requested a review from mitsudome-r June 27, 2024 11:26
    @xmfcx xmfcx added the tag:pr-agent Mark to enable PR-Agent for automated reviews. (used-by-ci) label Jun 27, 2024
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 27, 2024

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (6ddc256)

    fix action version
    906f89f 
    Signed-off-by: M. Fatih Cırıt <[email protected]>
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 27, 2024

    @xmfcx xmfcx marked this pull request as ready for review June 27, 2024 11:48
    remove dummy change
    5e128e8 
    Signed-off-by: M. Fatih Cırıt <[email protected]>
    @github-actions github-actions bot removed the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jun 27, 2024
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 27, 2024

    @veqcc -san, once this is merged, I will create the PR to link the new

    fix for all other derivatives too
    2fe2b35 
    Signed-off-by: M. Fatih Cırıt <[email protected]>
    @xmfcx xmfcx added the type:arm64 ARM64 architecture issues or compatibility. label Jun 27, 2024
    @xmfcx xmfcx changed the title ci(build-and-test-differential): fix cache and merge clang-tidy ci(build-and-test-x): fix cache and merge clang-tidy Jun 27, 2024
    print the variable for eye candy
    619df7f 
    Signed-off-by: M. Fatih Cırıt <[email protected]>
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 27, 2024

    /describe

    @xmfcx xmfcx removed the request for review from RyuYamamoto June 27, 2024 12:46
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (619df7f)

    @xmfcx xmfcx merged commit 8df1d33 into main Jun 27, 2024
    25 of 27 checks passed
    @xmfcx xmfcx deleted the ci/separate-cuda-nocuda-cache branch June 27, 2024 12:50
    @xmfcx xmfcx mentioned this pull request Jun 27, 2024
    Closed
    3 tasks
    mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
    @xmfcx @mitukou1109
    ci(build-and-test-x): fix cache and merge clang-tidy (autowarefoundat…
    0f730b9 
    …ion#7723)

Signed-off-by: M. Fatih Cırıt <[email protected]>
    palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
    @xmfcx @palas21
    ci(build-and-test-x): fix cache and merge clang-tidy (autowarefoundat…
    3e0f378 
    …ion#7723)

Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: palas21 <[email protected]>
    tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
    @xmfcx @tby-udel
    ci(build-and-test-x): fix cache and merge clang-tidy (autowarefoundat…
    2469d1e 
    …ion#7723)

Signed-off-by: M. Fatih Cırıt <[email protected]>
    KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
    @xmfcx
    ci(build-and-test-x): fix cache and merge clang-tidy (#7723)
    424ee38 
    Signed-off-by: M. Fatih Cırıt <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

    Assignees

    @xmfcx xmfcx

    Labels
    run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:pr-agent Mark to enable PR-Agent for automated reviews. (used-by-ci) type:arm64 ARM64 architecture issues or compatibility. type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
    Projects
    No open projects
    Autoware Labs
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @xmfcx