Avoid calling env_process._get_qemu_version from test cases #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YongxueHong could you have a look? Based on #3954 I'd also appreciate your input @hellohellenmao @maxujun @BohdanMar @fbq815 on @nanliu-r I would also appreciate if you could have a look onto If you all would rather split this into 2 separate PRs, tell me. |
YongxueHong
previously approved these changes
Jan 14, 2025
Running qemu version was extracted by calling virttest.env_process._get_qemu_version. However, that function was removed from avocado-vt in fe5614d78ce74395544d6c2834573e0e6f25eb5e. It was done assuming it wasn't used outside virttest.env_process, as it was considered to be private (due to the `_` prefix). However, virttest.utils_qemu provides the public get_qemu_version function which gives a quite similar result. This patch, replaces virttest.env_process._get_qemu_version by virttest.utils_qemu.get_qemu_version in the thin_write_in_qemu_img_commit test case. Signed-off-by: Beñat Gartzia <[email protected]>
Running qemu version was extracted by calling virttest.env_process._get_qemu_version. However, that function was removed from avocado-vt in fe5614d78ce74395544d6c2834573e0e6f25eb5e. It was done assuming it wasn't used outside virttest.env_process, as it was considered to be private (due to the `_` prefix). However, virttest.utils_qemu provides the public get_qemu_version which gives a quite similar result. This patch, replaces virttest.env_process._get_qemu_version by virttest.utils_qemu.get_qemu_version in the cpu_info_check test case. Signed-off-by: Beñat Gartzia <[email protected]>
bgartzi
force-pushed
the
avoid-_get_qemu_version
branch
from
25b65a3 to
e7c8687
Compare
|
Sorry for the noise @YongxueHong I forgot to select the right part of the tuple in Thanks also for having a look that quickly. |
YongxueHong
approved these changes
Jan 15, 2025
|
@bgartzi Hi, looks good to me, sorry for the later reply. |
nanliu-r
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_qemu_versionwas removed fromvirttest.env_processin avocado-framework/avocado-vt@fe5614dThere were a bunch of test cases that were using the private function, and so affected by this removal, such as the one being fixed in #4249
This path updates the other test cases so they call the public (and still available) function from virttest instead.
ID: 3313