Virtiofs: Reboot vm during virtiofs is working #4221
Conversation
qcheng-redhat
force-pushed
the
virtiofs_reboot
branch
from
4e21952 to
43d8d17
Compare
|
Hi @hellohellenmao Please help review this patch. Tested with Win10 and rhel guests, both passed. |
qemu/tests/virtio_fs_share_data.py
Outdated
| "After reboot: %s\n", | ||
| (vfsd_num_bf, vfsd_num_af), | ||
| for reboot_cmd in ["shell", "system_reset"]: | ||
| error_context.context( |
There was a problem hiding this comment.
As there are two reboot operations, for the second reboot please re-mount the viofs file system.
There was a problem hiding this comment.
Thank you for review. Updated. @xiagao
qcheng-redhat
force-pushed
the
virtiofs_reboot
branch
from
43d8d17 to
291e9fa
Compare
|
It looks good to me. @qcheng-redhat Could you update the latest results with the latest codes? |
|
Tested with RHEL 9， Win10 and Win11 guests. RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 |
qemu/tests/virtio_fs_share_data.py
Outdated
| "Before reboot: %s\n" | ||
| "After reboot: %s\n", | ||
| (vfsd_num_bf, vfsd_num_af), | ||
| for reboot_cmd in ["shell", "system_reset"]: |
There was a problem hiding this comment.
@qcheng-redhat I am thinking that is it possible to splite the reboot behavior in the cfg file, something like reboot_shell and system_reset under - with_reboot: in virtio_fs_share_data.cfg file, which will be very clear for users that there are 2 types of reboot for this scenario.
There was a problem hiding this comment.
Updated, Please review. Thanks.
Signed-off-by: qcheng-redhat <qcheng@redhat.com>
qcheng-redhat
force-pushed
the
virtiofs_reboot
branch
from
291e9fa to
fe1d06b
Compare
|
(1/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data.with_cache.auto.with_reboot.with_system_reset.q35: STARTED And all the logs look good to me. |
|
@YongxueHong Could you please help to take a review here and help to merge if everything is okay from your side? |
Reboot vm by system_reset during virtiofs is working
ID: 3129