Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Legacy Wood procedural #1412

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Adding Legacy Wood procedural #1412

merged 2 commits into from
Jan 23, 2025

Conversation

zicher3d
Copy link
Collaborator

Adding Legacy Wood procedural and 2 utility graphs

  • legacy_wood
  • util_woodfactor
  • util_woodnoise

Fixing a node category in Waves that was left unchanged after export.

Adding Legacy Wood procedural and 2 utility graphs
- legacy_wood
- util_woodfactor
- util_woodnoise

Fixing a node category in Waves that was left unchanged after export.
Copy link
Collaborator

@ashwinbhat ashwinbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would suggest renaming the input names to something more descriptive.
Also for backlog tracking, we need to add tests/examples

@@ -182,6 +182,41 @@
<output name="out" type="color3" />
</nodedef>

<nodedef name="ND_util_woodnoise_float" node="util_woodnoise">
<input name="x" type="float" uisoftmin="0.0" uisoftmax="1.0" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this input from x to something that would be clear. I think it's used mainly as a factor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that yesterday. It's technically a distance. Then I stuck to the function parameter name.
I believe this is a worthy change. Let me do it.

Comment on lines +204 to +205
<input name="color1" type="color3" value="0.603, 0.445, 0.072" uisoftmin="0,0,0" uisoftmax="1,1,1" />
<input name="color2" type="color3" value="0.212, 0.072, 0" uisoftmin="0,0,0" uisoftmax="1,1,1" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest giving a better name primary grain color and secondary grain color etc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I always matched the Protein names for all my classes. This would be an exception if we do it. See the current UI.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess skip for now. I don't think eventually we will need to propagate legacy names. We could publish new names and document them.

Simple rename of the "util_woodnoise" input "x" to "distance"

The input order where util_woodnoise is used has changed. That's LookdevX decision (maybe the order the input are connected?). Makes the diff look more different than what it actually is.
@zicher3d zicher3d merged commit 4ff7a63 into adsk_contrib/dev Jan 23, 2025
30 of 32 checks passed
@zicher3d zicher3d deleted the zicher/legacy_wood branch January 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants