-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Legacy Wood procedural #1412
Conversation
Adding Legacy Wood procedural and 2 utility graphs - legacy_wood - util_woodfactor - util_woodnoise Fixing a node category in Waves that was left unchanged after export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would suggest renaming the input names to something more descriptive.
Also for backlog tracking, we need to add tests/examples
@@ -182,6 +182,41 @@ | |||
<output name="out" type="color3" /> | |||
</nodedef> | |||
|
|||
<nodedef name="ND_util_woodnoise_float" node="util_woodnoise"> | |||
<input name="x" type="float" uisoftmin="0.0" uisoftmax="1.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename this input from x
to something that would be clear. I think it's used mainly as a factor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered that yesterday. It's technically a distance. Then I stuck to the function parameter name.
I believe this is a worthy change. Let me do it.
<input name="color1" type="color3" value="0.603, 0.445, 0.072" uisoftmin="0,0,0" uisoftmax="1,1,1" /> | ||
<input name="color2" type="color3" value="0.212, 0.072, 0" uisoftmin="0,0,0" uisoftmax="1,1,1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest giving a better name primary grain color and secondary grain color etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess skip for now. I don't think eventually we will need to propagate legacy names. We could publish new names and document them.
Simple rename of the "util_woodnoise" input "x" to "distance" The input order where util_woodnoise is used has changed. That's LookdevX decision (maybe the order the input are connected?). Makes the diff look more different than what it actually is.
Adding Legacy Wood procedural and 2 utility graphs
Fixing a node category in Waves that was left unchanged after export.