Fix redundant values #1399
Merged
Fix redundant values #1399
+172
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in graph editor, a lot of inputs had connections to an interfacename and a value, when only the interfacename was needed. This is fixed in future graph editor builds, but probably only for new created inputs, so a clean slate is necessary for safety. The graphs were working in Viewer, but causing issues in LookdevX. LookdevX now handles this case if we face it again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in graph editor, a lot of inputs had connections to an interfacename and a value, when only the interfacename was needed.
This is fixed in future graph editor builds, but probably only for new created inputs, so a clean slate is necessary for safety.
The graphs were working in Viewer, but causing issues in LookdevX. LookdevX now handles this case if we face it again in the future.