Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/MacOS ADesktop Implementation #388

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

na2axl
Copy link
Contributor

@na2axl na2axl commented Dec 15, 2024

Hey @Alex2772

I've been trying to make my app available for Linux (and also for MacOS even if it's on less priority), but encountered some usability issues, mostly for platform stuff, since the renderer works good on Linux (but has some bugs on MacOS).

This PR is my attempt to implement ADesktop for both Linux and MacOS, and so far, I have good results.

I'm opening the PR as draft so you can give me guidance to improve the current implementations, while I'm adding the remaining ones.

PS: My app is now globally available here: https://studio.amplitudeaudiosdk.com

@na2axl na2axl mentioned this pull request Dec 15, 2024
Copy link
Collaborator

@Alex2772 Alex2772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts!

aui.views/src/AUI/Platform/linux/AMessageBoxImpl.cpp Outdated Show resolved Hide resolved
aui.views/src/AUI/Platform/linux/ADBus.cpp Outdated Show resolved Hide resolved
aui.views/src/AUI/Platform/linux/ADBus.h Show resolved Hide resolved
aui.views/src/AUI/Platform/linux/ADBus.cpp Show resolved Hide resolved
@Alex2772 Alex2772 mentioned this pull request Dec 15, 2024
@Alex2772
Copy link
Collaborator

renderer works good on Linux (but has some bugs on MacOS).

Could you please clarify which bugs you have encountered? I think we should highlight them.

@Alex2772
Copy link
Collaborator

Alex2772 commented Dec 15, 2024

PS: My app is now globally available here: https://studio.amplitudeaudiosdk.com/

Good news! Can I add a reference to your application in README.md as a real life project using AUI (#352)? Does its source available?

P.S. checked it out, looks nice! I've wanted to make sure that you blocked devtools window in your application but it seems like you have already done it

@na2axl
Copy link
Contributor Author

na2axl commented Dec 15, 2024

Could you please clarify which bugs you have encountered? I think we should highlight them.

I will open an issue with them, but since I'm not able to properly launch my app the list may be uncomplete. But it's mostly sizing issues of views, will provide screenshots.

Can I add a reference to your application in README.md as a real life project using AUI (#352)?

Yes for sure!

Does its source available?

No sadly, the app is proprietary and plans to be commercial software.

I've wanted to make sure that you blocked devtools window in your application but it seems like you have already done it

I can assure you I did nothing like this 😄, I taught the dev tools got disabled automatically for release builds. Thanks for the hint I will disable this manually.

aui.views/CMakeLists.txt Outdated Show resolved Hide resolved
@Alex2772
Copy link
Collaborator

Is there are any ongoing changes planned? (despite the broken build)

@na2axl na2axl marked this pull request as ready for review December 16, 2024 09:36
@na2axl
Copy link
Contributor Author

na2axl commented Dec 16, 2024

Is there are any ongoing changes planned? (despite the broken build)

The latest change I wanted to implement was the native message dialogs on MacOS. With that I think the PR is ready. I did not implement iconOfFile and playSystemSound in Linux since I don't know yet the good way to do it

@Alex2772
Copy link
Collaborator

Is there are any ongoing changes planned? (despite the broken build)

The latest change I wanted to implement was the native message dialogs on MacOS. With that I think the PR is ready. I did not implement iconOfFile and playSystemSound in Linux since I don't know yet the good way to do it

Good!

Looks like pipelines for linux are broken. To make things simpler, I'll merge this PR to a dedicated branch to continue working on Linux fixes. Thank you for contribution!

@Alex2772 Alex2772 changed the base branch from develop to feat/desktop-impl December 16, 2024 10:24
@Alex2772 Alex2772 merged commit 811ccbc into aui-framework:feat/desktop-impl Dec 16, 2024
13 of 18 checks passed
@Alex2772 Alex2772 mentioned this pull request Dec 16, 2024
Alex2772 added a commit that referenced this pull request Dec 16, 2024
* Linux/MacOS ADesktop Implementation (#388)

* feat(macos): Get mouse position.

* macos file picker dialog.

* macos system sounds.

* macos icon of file.

* linux file/folder browser fixed.

* linux message box.

* macos modal with parent window.

* install missing package for Linux ci builds.

* apply reviews.

* fix GTK libray dirs.

* pass utf8 data to NSString.

* macos set cursor position.

* applied @Alex2772 patch.

* macos native message dialogs.

* moved gtk_init

---------

Co-authored-by: Nana Axel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants