-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux/MacOS ADesktop Implementation #388
Linux/MacOS ADesktop Implementation #388
Conversation
69afe22
to
37d78e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your efforts!
Could you please clarify which bugs you have encountered? I think we should highlight them. |
Good news! Can I add a reference to your application in README.md as a real life project using AUI (#352)? Does its source available? P.S. checked it out, looks nice! I've wanted to make sure that you blocked devtools window in your application but it seems like you have already done it |
I will open an issue with them, but since I'm not able to properly launch my app the list may be uncomplete. But it's mostly sizing issues of views, will provide screenshots.
Yes for sure!
No sadly, the app is proprietary and plans to be commercial software.
I can assure you I did nothing like this 😄, I taught the dev tools got disabled automatically for release builds. Thanks for the hint I will disable this manually. |
ad5b28e
to
530efd7
Compare
Is there are any ongoing changes planned? (despite the broken build) |
The latest change I wanted to implement was the native message dialogs on MacOS. With that I think the PR is ready. I did not implement |
Good! Looks like pipelines for linux are broken. To make things simpler, I'll merge this PR to a dedicated branch to continue working on Linux fixes. Thank you for contribution! |
811ccbc
into
aui-framework:feat/desktop-impl
* Linux/MacOS ADesktop Implementation (#388) * feat(macos): Get mouse position. * macos file picker dialog. * macos system sounds. * macos icon of file. * linux file/folder browser fixed. * linux message box. * macos modal with parent window. * install missing package for Linux ci builds. * apply reviews. * fix GTK libray dirs. * pass utf8 data to NSString. * macos set cursor position. * applied @Alex2772 patch. * macos native message dialogs. * moved gtk_init --------- Co-authored-by: Nana Axel <[email protected]>
Hey @Alex2772
I've been trying to make my app available for Linux (and also for MacOS even if it's on less priority), but encountered some usability issues, mostly for platform stuff, since the renderer works good on Linux (but has some bugs on MacOS).
This PR is my attempt to implement
ADesktop
for both Linux and MacOS, and so far, I have good results.I'm opening the PR as draft so you can give me guidance to improve the current implementations, while I'm adding the remaining ones.
PS: My app is now globally available here: https://studio.amplitudeaudiosdk.com