dom: Hide debugging extension methods behind a pref.

atouchet · Jul 15, 2020 · e6cdfdd · e6cdfdd
1 parent 9fe92ec
commit e6cdfdd
Show file tree

Hide file tree

Showing 14 changed files with 19 additions and 4 deletions.
diff --git a/components/config/prefs.rs b/components/config/prefs.rs
@@ -187,6 +187,9 @@ mod gen {
                     enabled: bool,
                     timeout_seconds: i64,
                 },
+                servo_helpers: {
+                    enabled: bool,
+                },
                 servoparser: {
                     async_html_tokenizer: {
                         enabled: bool,

diff --git a/components/script/dom/webidls/Window.webidl b/components/script/dom/webidls/Window.webidl
@@ -136,8 +136,11 @@ partial interface Window {
 
 // Proprietary extensions.
 partial interface Window {
+  [Pref="dom.servo_helpers.enabled"]
   void debug(DOMString arg);
+  [Pref="dom.servo_helpers.enabled"]
   void gc();
+  [Pref="dom.servo_helpers.enabled"]
   void trap();
 };
 

diff --git a/resources/prefs.json b/resources/prefs.json
@@ -19,6 +19,7 @@
   "dom.permissions.testing.allowed_in_nonsecure_contexts": false,
   "dom.serviceworker.enabled": false,
   "dom.serviceworker.timeout_seconds": 60,
+  "dom.servo_helpers.enabled": false,
   "dom.servoparser.async_html_tokenizer.enabled": false,
   "dom.shadowdom.enabled": false,
   "dom.svg.enabled": false,

diff --git a/resources/user-agent-js/00.example.js b/resources/user-agent-js/00.example.js
@@ -3,3 +3,4 @@
 // Files are sorted alphabetically. When committing polyfills
 // order them with numbers, e.g. `01.innerhtml.js` will be executed before
 // `05.jquery.js`
+onunhandledrejection = (e) => console.error("xxxjdm error: " + JSON.stringify(e.reason));
diff --git a/tests/wpt/mozilla/meta-layout-2020/mozilla/media_query_list_gc.html.ini b/tests/wpt/mozilla/meta-layout-2020/mozilla/media_query_list_gc.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta-layout-2020/mozilla/prototypes.html.ini b/tests/wpt/mozilla/meta-layout-2020/mozilla/prototypes.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta-layout-2020/mozilla/trace_null.html.ini b/tests/wpt/mozilla/meta-layout-2020/mozilla/trace_null.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta-layout-2020/mozilla/transitionend_safety.html.ini b/tests/wpt/mozilla/meta-layout-2020/mozilla/transitionend_safety.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta-layout-2020/mozilla/weakref.html.ini b/tests/wpt/mozilla/meta-layout-2020/mozilla/weakref.html.ini
@@ -1,4 +1,3 @@
 [weakref.html]
-  [Weak references work]
-    expected: FAIL
-
+  type: testharness
+  prefs: ["dom.testbinding.enabled:true", "dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta/mozilla/media_query_list_gc.html.ini b/tests/wpt/mozilla/meta/mozilla/media_query_list_gc.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta/mozilla/prototypes.html.ini b/tests/wpt/mozilla/meta/mozilla/prototypes.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta/mozilla/trace_null.html.ini b/tests/wpt/mozilla/meta/mozilla/trace_null.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta/mozilla/transitionend_safety.html.ini b/tests/wpt/mozilla/meta/mozilla/transitionend_safety.html.ini
@@ -0,0 +1 @@
+prefs: ["dom.servo_helpers.enabled:true"]
diff --git a/tests/wpt/mozilla/meta/mozilla/weakref.html.ini b/tests/wpt/mozilla/meta/mozilla/weakref.html.ini
@@ -1,3 +1,3 @@
 [weakref.html]
   type: testharness
-  prefs: [dom.testbinding.enabled:true]
+  prefs: ["dom.testbinding.enabled:true", "dom.servo_helpers.enabled:true"]