Skip to content

Commit

Permalink
style: Add support for is() and where() selectors (servo#34066)
Browse files Browse the repository at this point in the history
Additionally, changes now need to be made to `servo.css` in order to
ensure that `<button>` text is centered the same way that it is for
`<input type=button>`. In the past the rule for centering text for the
latter was ignored because it used `:is()`.

Signed-off-by: Martin Robinson <[email protected]>
  • Loading branch information
mrobinson authored Nov 19, 2024
1 parent 975e2ae commit 0eda2de
Show file tree
Hide file tree
Showing 22 changed files with 12 additions and 393 deletions.
24 changes: 12 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion resources/servo.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ input {
color: black;
font-family: sans-serif;
font-size: 0.8333em;
text-align: left;
}

textarea {
Expand Down
21 changes: 0 additions & 21 deletions tests/wpt/meta/css/css-cascade/scope-evaluation.html.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
[Single scope]
expected: FAIL

[Scope can not match its own root without :scope]
expected: FAIL

[Selecting self with :scope]
expected: FAIL

Expand All @@ -26,15 +23,9 @@
[Multiple scopes from same @scope-rule, only one limited]
expected: FAIL

[Multiple scopes from same @scope-rule, both limited]
expected: FAIL

[Nested scopes]
expected: FAIL

[Nested scopes, reverse]
expected: FAIL

[Nested scopes, with to-selector]
expected: FAIL

Expand All @@ -47,21 +38,9 @@
[Simulated inclusive scoping limit]
expected: FAIL

[Scope with no elements]
expected: FAIL

[:scope direct adjacent sibling]
expected: FAIL

[:scope indirect adjacent sibling]
expected: FAIL

[Relative selector inside @scope]
expected: FAIL

[:scope in two different compounds]
expected: FAIL

[Scope root with :has()]
expected: FAIL

Expand Down
6 changes: 0 additions & 6 deletions tests/wpt/meta/css/css-cascade/scope-visited-cssom.html.ini
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,9 @@
[:link as scoping root]
expected: FAIL

[:visited as scoping root]
expected: FAIL

[:not(:visited) as scoping root]
expected: FAIL

[:not(:link) as scoping root]
expected: FAIL

[:link as scoping root, :scope]
expected: FAIL

Expand Down

This file was deleted.

15 changes: 0 additions & 15 deletions tests/wpt/meta/css/selectors/invalidation/is.html.ini

This file was deleted.

3 changes: 0 additions & 3 deletions tests/wpt/meta/css/selectors/invalidation/not-002.html.ini

This file was deleted.

15 changes: 0 additions & 15 deletions tests/wpt/meta/css/selectors/invalidation/where.html.ini

This file was deleted.

2 changes: 0 additions & 2 deletions tests/wpt/meta/css/selectors/is-default-ns-002.html.ini

This file was deleted.

6 changes: 0 additions & 6 deletions tests/wpt/meta/css/selectors/is-nested.html.ini

This file was deleted.

4 changes: 0 additions & 4 deletions tests/wpt/meta/css/selectors/is-specificity-shadow.html.ini

This file was deleted.

3 changes: 0 additions & 3 deletions tests/wpt/meta/css/selectors/is-specificity.html.ini

This file was deleted.

45 changes: 0 additions & 45 deletions tests/wpt/meta/css/selectors/is-where-basic.html.ini

This file was deleted.

4 changes: 0 additions & 4 deletions tests/wpt/meta/css/selectors/is-where-error-recovery.html.ini

This file was deleted.

54 changes: 0 additions & 54 deletions tests/wpt/meta/css/selectors/is-where-not.html.ini

This file was deleted.

4 changes: 0 additions & 4 deletions tests/wpt/meta/css/selectors/is-where-pseudo-classes.html.ini

This file was deleted.

This file was deleted.

Loading

0 comments on commit 0eda2de

Please sign in to comment.