-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy eval generification #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66dd269
to
7393938
Compare
7393938
to
22e5672
Compare
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
chrispatrick
reviewed
Jan 2, 2024
Looking pretty good! Just added a handful of comments 🙂 |
chrispatrick
reviewed
Jan 2, 2024
a294e21
to
22fc6f8
Compare
22fc6f8
to
3ee05c0
Compare
chrispatrick
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly deletions following off of #30.
I have removed most of the policy-specific result types like
GetPackagesResult
and replaced them with generic query methods. Each downstream policy repository should define its own queries and query types to match its needs.The split of async/subscription/local skill handlers have been merged into a single one. This should reduce effort required when a change needs to affect all of them. Each capability is now selected as an option when creating the handler. Depending on which options are enabled, things like where the subscription data comes from or whether or not to transact are determined via hooks into the main flow.
As a demonstration of what this PR would look like when consumed, the "No Stale Base Images" and "Approved Base Images" policies have been converted at atomist-skills/policy-base-images.
A template repository which can be used to generate new policy repositories is at atomist-skills/template-go-policy.