remove common policy logic #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispatrick
force-pushed
the
remove-common-policy-logic
branch
from
ce0a371 to
0858f3f
Compare
chrispatrick
force-pushed
the
remove-common-policy-logic
branch
from
0858f3f to
15adef2
Compare
felipecruz91
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Never fear - this logic will reappear in
poliwrathinstead.This should allow for faster development by removing the need to make changes in go-skill as well as the policy implementation and poliwrath.
It also unblocks potential new functionality in poliwrath by moving control of things like policy result storage into there.
Related PRs
None