Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add asyncapi3-channel-parameters rule #1083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AugustusWayne
Copy link

@AugustusWayne AugustusWayne commented Feb 6, 2025

Resolves #875

Description :

This PR addresses issue #875 by improving the handling of the asyncapi3-channel-parameters rule. The previous implementation had inconsistencies in how parameters were validated against AsyncAPI specifications, leading to potential misinterpretations or false positives.

Changes Introduced :

Enhanced validation logic to correctly verify channel parameters.
Fixed edge cases where valid parameters were incorrectly flagged as errors.
Improved error messages to provide more context for users.
Additional test cases were added to ensure robust rule enforcement.

Screenshot 2025-02-10 at 10 24 26 PM Screenshot 2025-02-10 at 10 24 47 PM Screenshot 2025-02-10 at 10 25 10 PM

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: b86de54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarqubecloud bot commented Feb 6, 2025

@AugustusWayne
Copy link
Author

@smoya @jonaslagoni @magicmatatjahu Can anyone please take a look at this pr? I'm happy to make any changes if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser do not validate and throw error when parameters are provided but address is null
2 participants