-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add dependency on building @asyncapi/parser
for turbo run test
#1078
base: master
Are you sure you want to change the base?
chore: add dependency on building @asyncapi/parser
for turbo run test
#1078
Conversation
|
Quality Gate passedIssues Measures |
This PR is supposed to fix exactly this failing test. |
I dont understand where the issue was. I see the test of the multiparser passed but not the parser; for some reason it ran for hours. Would you mind explaining how this change would fix that issue? |
When This change makes task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
/rtm |
It looks like the merging of this PR is blocked exactly due to the issue it fixes. 😄
Is there a way to disable this testing for this PR? |
Are you sure the turborepo config in use by this PR CI is not the one you modified? |
Yes, it is exactly the one I modify with this PR: So, currently, the testing of a fix for the testing fails due to a bug in the testing. That's why I need to have testing disabled specifically for this PR, so that the testing mechanism is fixed and can pass for all future PRs. |
Current PR testing is done using My PR modifies it in a way I explained so the testing will pass only for future PRs, not for this one: |
This PR instructs
turbo
to wait for the build of@asyncapi/parser
before executingturbo run test
.