Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing shortname from search_object defaults #97

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

dr-rodriguez
Copy link
Collaborator

With the verbose option, this will now also print out:

Using table 'Sources' with columns ['source'] for matching object names
Using table 'Names' with columns ['other_name'] for matching object names

Closes #96

@dr-rodriguez dr-rodriguez self-assigned this Feb 15, 2025
@dr-rodriguez dr-rodriguez added the enhancement New feature or request label Feb 15, 2025 — with GitHub Codespaces
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (05f7b5d) to head (b2be7a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   95.35%   95.36%           
=======================================
  Files          10       10           
  Lines        1119     1121    +2     
=======================================
+ Hits         1067     1069    +2     
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-rodriguez dr-rodriguez merged commit 0112ab7 into main Feb 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search_object and shortname
2 participants