Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: websocket publishing w/ auth #245

Merged
merged 5 commits into from
Feb 5, 2025
Merged

feat: websocket publishing w/ auth #245

merged 5 commits into from
Feb 5, 2025

Conversation

EvolveArt
Copy link
Contributor

@EvolveArt EvolveArt commented Feb 5, 2025 •
edited
Loading

Closes #N/A

Introduced changes

  • Add a new --websocket-url option to the price pusher to publish on the API websocket endpoint
  • Websocket publishing supports authentication by sending login message

TODO

  • pass the session in the api client instead of opening a new connection every time
  • add --burst mode to price pusher to send data in the channel as soon as its available instead of waiting to produce a batch

  • This PR contains breaking changes

@EvolveArt EvolveArt mentioned this pull request Feb 5, 2025
Merged
@EvolveArt EvolveArt requested a review from akhercha February 5, 2025 09:43
akhercha
akhercha approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gud for me, nice

@EvolveArt EvolveArt merged commit c99013f into master Feb 5, 2025
12 of 13 checks passed
@EvolveArt EvolveArt deleted the 0x/websocket-api branch February 5, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhercha akhercha akhercha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvolveArt @akhercha