refactor(pairing): move CQEx select queries to exandra #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
davidebriani
added
app:pairing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1082 +/- ##
===============================================
+ Coverage 67.03% 67.08% +0.04%
===============================================
Files 265 315 +50
Lines 7084 7635 +551
===============================================
+ Hits 4749 5122 +373
- Misses 2335 2513 +178 ☔ View full report in Codecov by Sentry. |
davidebriani
force-pushed
the
pairing-ecto-queries
branch
2 times, most recently
from
2220395 to
5130cf0
Compare
davidebriani
commented
Feb 25, 2025
| # Consider a failing database as a negative answer | ||
| _ = | ||
| Logger.warning( | ||
| "Failed to verify if unconfirmed device #{Device.encode_device_id(device_id)} exists, reason: #{inspect(reason)}", | ||
| "Failed to verify if unconfirmed device #{Device.encode_device_id(device_id)} exists, reason: #{inspect(err)}", |
There was a problem hiding this comment.
Since err is always a Xandra error (Xandra.Error or Xandra.ConnectionError) we can use Exception.message(err) instead of inspect(err).
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
Use Ecto to compose and run the query. Signed-off-by: Davide Briani <[email protected]>
davidebriani
force-pushed
the
pairing-ecto-queries
branch
from
5130cf0 to
1a31faf
Compare
Annopaolo
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pairing runs queries through CQEx, which is deprecated, and we need to rework the project interaction with the database.
This change moves the SELECT queries to Ecto with Exandra.
Does this PR introduce a user-facing change?