Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File copying errors #753

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

leotsarev
Copy link
Contributor

Summary of the changes

  • Improve logging when file copying file failed
  • Retry file copying 3 times

Some kind of improvement to #697

@jimmylewis
Copy link
Contributor

@leotsarev build failure indicates you missed a reference to the CopyFileAsync method.

@leotsarev
Copy link
Contributor Author

It's hard to build locally. I can't found most Nugets. I'll look into

@jimmylewis
Copy link
Contributor

It's hard to build locally. I can't found most Nugets. I'll look into

Sounds related to #728, I wonder if you have a different SDK version that to different runtime packages. Can you list your Nuget restore issues there? And maybe the workaround in #728 (comment) can help work around that.

@leotsarev leotsarev force-pushed the log-file-copying-errors branch from 61bb7af to ff78e14 Compare May 22, 2024 08:52
@leotsarev
Copy link
Contributor Author

@phil-allen-msft phil-allen-msft merged commit 8ede78d into aspnet:main May 24, 2024
2 checks passed
@leotsarev leotsarev deleted the log-file-copying-errors branch July 9, 2024 16:12
@leotsarev
Copy link
Contributor Author

@phil-allen-msft may be you will release prerelease version with this change? I'm eager to look into errors...

@phil-allen-msft
Copy link
Contributor

@leotsarev , I believe you will find that 17.11 Preview 2 of Visual Studio has this change. Please let us know what you find.

@leotsarev
Copy link
Contributor Author

leotsarev commented Jul 16, 2024

Whats version of CLI tools and nuget package?

@leotsarev
Copy link
Contributor Author

@phil-allen-msft could I test it using CLI tools / Nuget package ?

@leotsarev
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants