Update first_timers.py #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i have actually formatted the previous code
|
i have formatted the code |
arshadkazmi42
requested changes
Oct 14, 2023
Comment on lines
+19
to
20
| # Logging helper functions | ||
| def log_info(message): |
There was a problem hiding this comment.
I think we should get rid of the log comment. I do not see any value from the comment.
There was a problem hiding this comment.
I don't think this is resolved.
first_timers/first_timers.py
Outdated
| associated with the credentials. | ||
| Also takes a parameter 'debug', which can prevent actual tweeting. | ||
| Returns a list of tweets. | ||
| associated with the credentials. Also takes a parameter 'debug', which can |
There was a problem hiding this comment.
We do not need this change. The comment from Also takes a parameter .... is expected to be on the second line. Can you revert this back
first_timers/first_timers.py
Outdated
| language_hashTags = ''.join( | ||
| ' #{}'.format(lang) for lang in issue['languages'] | ||
| ) | ||
| language_hashTags = ''.join(' #{}'.format(lang) for lang in issue['languages']) |
There was a problem hiding this comment.
Same as above, revert this back. It is easier to read it when it is multi line
first_timers/first_timers.py
Outdated
| """Limit the number of issues saved in our DB.""" | ||
| sorted_issues = sorted(issues, key=lambda x: x['updated_at'], reverse=True) | ||
| return sorted_issues[:limit_len] | ||
| hashTags = hashTags[:max_hashtags_len - 1] + E |
There was a problem hiding this comment.
Seems like you have deleted all the code after this line. Can you revert this please.
pls review it and tell if anything is wrong
|
@AniketTripathi05 Let me know once you are done with the fixes. I will review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have actually formatted the previous code
Fixes #issuenumber
Check everything which applies
#h1