-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pyinstaller Support #41
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds support for building the project using PyInstaller. A new spec file, File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arkrow - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a version range for PyInstaller in the future to allow for minor updates without breaking the build process.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
runtime_hooks=[], | ||
excludes=[], | ||
noarchive=False, | ||
optimize=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider increasing optimization level for production
For a production release, consider setting 'optimize' to 1 or 2 for better performance. However, be aware that this can make debugging more difficult.
optimize=0, | |
optimize=2, |
__version__
approach to read fromimportlib.metadata.version
is not compatible since no metadata is present. This might be addressed in a future commit, but this needs to be manually set for now.To use, install the project and it's requirements in a venv, along with
pyinstaller==6.9.0
and then:Summary by Sourcery
Introduce PyInstaller support by adding a spec file to enable building the project into an executable. This allows users to package the application without relying on poetry or plugins.
New Features: