Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyinstaller Support #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Pyinstaller Support #41

wants to merge 1 commit into from

Conversation

arkrow
Copy link
Owner

@arkrow arkrow commented Aug 9, 2024

  • Not dependent on poetry or plugins like Add PyInstaller & Dynamic Versioning Support #40
  • The implemented __version__ approach to read from importlib.metadata.version is not compatible since no metadata is present. This might be addressed in a future commit, but this needs to be manually set for now.

To use, install the project and it's requirements in a venv, along with pyinstaller==6.9.0 and then:

pyinstaller pymusiclooper.spec

Summary by Sourcery

Introduce PyInstaller support by adding a spec file to enable building the project into an executable. This allows users to package the application without relying on poetry or plugins.

New Features:

  • Add support for PyInstaller by including a new spec file for building the project into an executable.

Copy link

sourcery-ai bot commented Aug 9, 2024

Reviewer's Guide by Sourcery

This pull request adds support for building the project using PyInstaller. A new spec file, pymusiclooper.spec, has been introduced to configure the build process. The spec file includes the necessary configurations to package the sounddevice library and other dependencies, and sets up the Analysis and EXE objects required by PyInstaller.

File-Level Changes

Files Changes
pymusiclooper.spec Added PyInstaller spec file to support building the project into an executable.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arkrow - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a version range for PyInstaller in the future to allow for minor updates without breaking the build process.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

runtime_hooks=[],
excludes=[],
noarchive=False,
optimize=0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider increasing optimization level for production

For a production release, consider setting 'optimize' to 1 or 2 for better performance. However, be aware that this can make debugging more difficult.

Suggested change
optimize=0,
optimize=2,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant