Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): Add VerifyBGPPeerSession + minor fixes on other BGP tests #987

Merged
merged 8 commits into from
Jan 2, 2025
Merged

feat(anta.tests): Add VerifyBGPPeerSession + minor fixes on other BGP tests #987

merged 8 commits into from
Jan 2, 2025

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Dec 24, 2024 •
edited
Loading

TODO:

  • Check CodSpeed performance
  • Add IPv4 under the fields
  • Remove VRF check on VerifyBGPPeerMPCaps to be consistent with other tests
  • Update docstrings to avoid saying we check the VRF + the peer, one statement is enough

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #987 will not alter performance

Comparing carl-baillargeon:fix/bgp_tests (3570157) with main (58c4de8)

Summary

✅ 22 untouched benchmarks

@carl-baillargeon carl-baillargeon marked this pull request as draft December 26, 2024 12:57
@carl-baillargeon carl-baillargeon changed the title fix(anta.tests): Minor fixes on BGP tests feat(anta.tests): Add VerifyBGPPeerSession + minor fixes on other BGP tests Dec 31, 2024
@carl-baillargeon carl-baillargeon marked this pull request as ready for review December 31, 2024 19:26
@carl-baillargeon carl-baillargeon mentioned this pull request Dec 31, 2024
Open
19 tasks
gmuloc
gmuloc reviewed Jan 2, 2025
View reviewed changes
tests/units/anta_tests/routing/test_bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
@gmuloc gmuloc added this to the v1.3.0 milestone Jan 2, 2025
gmuloc
gmuloc reviewed Jan 2, 2025
View reviewed changes
examples/tests.yaml Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix my comment for consistency and feel free to merge 🚢

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit b765907 into aristanetworks:main Jan 2, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@vitthalmagadum vitthalmagadum Awaiting requested review from vitthalmagadum

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: feat(anta.tests)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carl-baillargeon @gmuloc @vitthalmagadum