feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

vitthalmagadum · 2024-09-24T10:57:29Z

Description

Verifies the route entries of given IPv4 network(s).

Supports `strict: True` to verify that only the specified nexthops by which routes are learned, requiring an exact match.

Expected Results
----------------
* Success: The test will pass if the route entry with given nexthop(s) present for given network(s).
* Failure: The test will fail if the routes not found or route entry with given nexthop(s) not present for given network(s).

Fixes #819

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)

github-actions · 2024-09-27T06:19:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-09-27T08:23:57Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

codspeed-hq · 2024-10-01T04:04:17Z

CodSpeed Performance Report

Merging #835 will not alter performance

_{Comparing vitthalmagadum:issue_819 (2e244ec) with main (1dd5a60)}

Summary

✅ 22 untouched benchmarks

sonarqubecloud · 2024-10-07T03:50:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anta/tests/routing/generic.py

tests/units/anta_tests/routing/test_generic.py

github-actions · 2024-12-02T20:54:10Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-12-31T12:27:21Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2025-01-20T19:17:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-01-20T19:19:35Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tests/routing/generic.py

anta/input_models/routing/generic.py

anta/tests/routing/generic.py

tests/units/input_models/routing/test_generic.py

anta/input_models/routing/generic.py

anta/tests/routing/generic.py

tests/units/anta_tests/routing/test_generic.py

tests/units/input_models/routing/test_generic.py

…ailure msg

carl-baillargeon

LGTM.

anta/tests/routing/generic.py

tests/units/anta_tests/routing/test_generic.py

for more information, see https://pre-commit.ci

sonarqubecloud · 2025-01-29T07:48:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

issue_819 Added TC for Route Entries

acf58f6

github-actions bot assigned vitthalmagadum Sep 24, 2024

github-actions bot added the state: conflict label Sep 27, 2024

Merge branch 'main' into issue_819

8104c91

vitthalmagadum force-pushed the issue_819 branch from ff97c98 to 8104c91 Compare September 27, 2024 08:23

github-actions bot removed the state: conflict label Sep 27, 2024

VitthalMagadum and others added 2 commits September 27, 2024 04:31

issue_819 removed redundant unit test added during conflicts resolve

c51d7fd

Merge branch 'main' into issue_819

79e93c3

Merge branch 'main' into issue_819

439a75d

MaheshGSLAB reviewed Oct 16, 2024

View reviewed changes

anta/tests/routing/generic.py Outdated Show resolved Hide resolved

tests/units/anta_tests/routing/test_generic.py Outdated Show resolved Hide resolved

tests/units/anta_tests/routing/test_generic.py Show resolved Hide resolved

github-actions bot added the state: conflict label Dec 2, 2024

Merge branch 'main' into issue_819

bb4bb76

github-actions bot removed the state: conflict label Dec 31, 2024

vitthalmagadum marked this pull request as draft January 14, 2025 13:44

vitthalmagadum added 3 commits January 15, 2025 23:08

Merge branch 'main' into issue_819

96e5ca2

Updated input model changes

4aab7f0

updated docstring in validator function

5a502c0

vitthalmagadum requested a review from carl-baillargeon January 16, 2025 05:40

vitthalmagadum marked this pull request as ready for review January 16, 2025 05:58

updated doctsring for VerifyIPv4RouteType.Input

1b46b65

github-actions bot added the state: conflict label Jan 20, 2025

Fix conflicts

0750cf8

github-actions bot removed the state: conflict label Jan 20, 2025

carl-baillargeon requested changes Jan 20, 2025

View reviewed changes

vitthalmagadum and others added 2 commits January 21, 2025 11:08

Merge branch 'main' into issue_819

44f7bec

Addressed review comments: updated test name, docstrings and failure msg

c873c25

vitthalmagadum requested a review from carl-baillargeon January 21, 2025 06:12

gmuloc requested changes Jan 21, 2025

View reviewed changes

Addressed review comments: updated unit tests, updated strict check f…

eaf1a2d

…ailure msg

vitthalmagadum requested a review from gmuloc January 22, 2025 03:05

carl-baillargeon approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' into issue_819

0922ffb

gmuloc changed the title ~~feat(anta): Added the test case to verify multiple routes with only specific nodes as next-hops~~ feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops Jan 28, 2025

gmuloc reviewed Jan 28, 2025

View reviewed changes

anta/tests/routing/generic.py Outdated Show resolved Hide resolved

Update anta/tests/routing/generic.py

7f10c75

gmuloc requested changes Jan 28, 2025

View reviewed changes

anta/tests/routing/generic.py Outdated Show resolved Hide resolved

tests/units/anta_tests/routing/test_generic.py Outdated Show resolved Hide resolved

pre-commit-ci bot and others added 2 commits January 28, 2025 13:16

[pre-commit.ci] auto fixes from pre-commit.com hooks

219164f

for more information, see https://pre-commit.ci

Addressed review comments: updated failure msgs use sorted

5767575

vitthalmagadum requested a review from gmuloc January 29, 2025 04:14

Merge branch 'main' into issue_819

2e244ec

gmuloc approved these changes Jan 29, 2025

View reviewed changes

gmuloc merged commit 08f4a3d into aristanetworks:main Jan 29, 2025
25 checks passed

github-actions bot added the rn: feat(anta) label Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

vitthalmagadum commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

codspeed-hq bot commented Oct 1, 2024 •

edited

Loading

sonarqubecloud bot commented Oct 7, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

carl-baillargeon left a comment

sonarqubecloud bot commented Jan 29, 2025

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

Conversation

vitthalmagadum commented Sep 24, 2024

Description

Checklist:

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

codspeed-hq bot commented Oct 1, 2024 • edited Loading

CodSpeed Performance Report

Merging #835 will not alter performance

Summary

sonarqubecloud bot commented Oct 7, 2024

Quality Gate passed

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

carl-baillargeon left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 29, 2025

Quality Gate passed

codspeed-hq bot commented Oct 1, 2024 •

edited

Loading