feat: Filter workflows by "Finished before" and "Created Since" via API. Fixes #13151

persist/sqldb/selector.go

@@ -1,6 +1,8 @@
 package sqldb
 
 import (
+	"time"
+
 	"github.com/upper/db/v4"
 
 	"github.com/argoproj/argo-workflows/v3/server/utils"
@@ -53,6 +55,12 @@ func BuildWorkflowSelector(in string, inArgs []any, tableName, labelTableName st
 			clauses = append(clauses, db.Raw("name like ?", options.Name+"%"))
 		}
 	}
+	if !options.CreatedAfter.IsZero() {
+		clauses = append(clauses, db.Raw("json_extract(workflow, '$.metadata.creationTimestamp') >= ?", options.CreatedAfter.Format(time.RFC3339)))
+	}
+	if !options.FinishedBefore.IsZero() {
+		clauses = append(clauses, db.Raw("finishedat <= ?", options.FinishedBefore))
+	}
 	if options.NamePrefix != "" {
 		clauses = append(clauses, db.Raw("name like ?", options.NamePrefix+"%"))
 	}

pkg/apiclient/workflow/workflow.proto

@@ -35,6 +35,8 @@ message WorkflowListRequest {
   string fields = 3;
   // Filter type used for name filtering. Exact | Contains | Prefix. Default to Exact
   string nameFilter = 4;
+  string createdAfter = 5;
+  string finishedBefore = 6;
 }
 
 message WorkflowResubmitRequest {

server/utils/list_options.go

@@ -13,13 +13,14 @@ import (
 )
 
 type ListOptions struct {
-	Namespace, Name            string
-	NamePrefix, NameFilter     string
-	MinStartedAt, MaxStartedAt time.Time
-	LabelRequirements          labels.Requirements
-	Limit, Offset              int
-	ShowRemainingItemCount     bool
-	StartedAtAscending         bool
+	Namespace, Name              string
+	NamePrefix, NameFilter       string
+	MinStartedAt, MaxStartedAt   time.Time
+	CreatedAfter, FinishedBefore time.Time
+	LabelRequirements            labels.Requirements
+	Limit, Offset                int
+	ShowRemainingItemCount       bool
+	StartedAtAscending           bool
 }
 
 func (l ListOptions) WithLimit(limit int) ListOptions {
@@ -52,7 +53,7 @@ func (l ListOptions) WithStartedAtAscending(ascending bool) ListOptions {
 	return l
 }
 
-func BuildListOptions(options metav1.ListOptions, ns, namePrefix, nameFilter string) (ListOptions, error) {
+func BuildListOptions(options metav1.ListOptions, ns, namePrefix, nameFilter, createdAfter, finishedBefore string) (ListOptions, error) {
 	if options.Continue == "" {
 		options.Continue = "0"
 	}
@@ -75,6 +76,21 @@ func BuildListOptions(options metav1.ListOptions, ns, namePrefix, nameFilter str
 	name := ""
 	minStartedAt := time.Time{}
 	maxStartedAt := time.Time{}
+	createdAfterTime := time.Time{}
+	finishedBeforeTime := time.Time{}
+
+	if createdAfter != "" {
+		createdAfterTime, err = time.Parse(time.RFC3339, createdAfter)
+		if err != nil {
+			return ListOptions{}, ToStatusError(err, codes.Internal)
+		}
+	}
+	if finishedBefore != "" {
+		finishedBeforeTime, err = time.Parse(time.RFC3339, finishedBefore)
+		if err != nil {
+			return ListOptions{}, ToStatusError(err, codes.Internal)
+		}
+	}
 	showRemainingItemCount := false
 	for _, selector := range strings.Split(options.FieldSelector, ",") {
 		if len(selector) == 0 {
@@ -126,6 +142,8 @@ func BuildListOptions(options metav1.ListOptions, ns, namePrefix, nameFilter str
 		Name:                   name,
 		NamePrefix:             namePrefix,
 		NameFilter:             nameFilter,
+		CreatedAfter:           createdAfterTime,
+		FinishedBefore:         finishedBeforeTime,
 		MinStartedAt:           minStartedAt,
 		MaxStartedAt:           maxStartedAt,
 		LabelRequirements:      requirements,