fix: Add OCI icon #583
Merged
fix: Add OCI icon #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Chong <[email protected]>
|
Thanks @blakepettersson for the review. This PR can be merged independently of your PR. Also the argo-ui 'version' containing this change can be pulled into Argo CD independent of your PR being merged or not. |
ishitasequeira
approved these changes
Jan 24, 2025
blakepettersson
added a commit
to blakepettersson/argo-cd
that referenced
this pull request
Jan 24, 2025
This adds the OCI icon from argoproj/argo-ui#583. Signed-off-by: Blake Pettersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the PR argoproj/argo-cd#18646
In the Repository settings panel, each OCI repo connection in the list of repository connections should have an icon. Other connection types, like Git, have icons of their own. This argo-ui PR will add the OCI icon, so, the repo list will look something like the following screenshot. No additional changes in the argo-cd PR will have to be done (The classname on the relevant element is set to
argo-icon-oci)Note, I copied the icon from here https://github.com/opencontainers/artwork/blob/main/oci/icon/black/oci-icon-black.svg and changed the viewbox size to 512x512 to match the size of the git icon.
The license is Apache License 2.0 - https://github.com/opencontainers/artwork/blob/main/LICENSE