-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kustomize ignore components - issues/18634 #21674
base: master
Are you sure you want to change the base?
feat: Kustomize ignore components - issues/18634 #21674
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
8272cf6
to
aaf19de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21674 +/- ##
==========================================
- Coverage 55.59% 55.54% -0.06%
==========================================
Files 340 340
Lines 57419 57445 +26
==========================================
- Hits 31924 31908 -16
- Misses 22807 22841 +34
- Partials 2688 2696 +8 ☔ View full report in Codecov by Sentry. |
8975964
to
dcbd254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you look into adding CLI and UI support for the new flag as part of this PR?
2ce7e91
to
73a063d
Compare
I looked in the existing CLI and UI and noticed that neither expose configuring Kustomize Components. |
73a063d
to
0bdc86d
Compare
@bradkwadsworth I think it probably still makes sense to expose the flag. Maybe not via the UI, but at least via the CLI. I think the code could be modeled off the Helm ignore missing values file equivalent field (assuming that has CLI/UI support, which it might not). |
3d33d8f
to
ee1d1b4
Compare
I was able to update the CLI, but couldn't find any references for something similar with the helm values files in the web UI. Updated some docs as well. |
d6f8b09
to
78adaa5
Compare
exist Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
78adaa5
to
871338b
Compare
Added ability to ignore Kustomize component directory if it does not exist. A new field called
ignoreMissingComponents
, if enabled, will verify if a given components directory exists and if not will log a debug message. Only found component directories will be used ifignoreMissingComponents
is set to true.Fixes #18634
Checklist: