fix(appproject): prevent appproject deletion

[KojoRising]

Fixes #21111

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[KojoRising]

@agaudreault, PR here.

[codecov]

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.

Project coverage is 55.29%. Comparing base (f6a84a4) to head (4a5f7c4).

Files with missing lines	Patch %	Lines
controller/appcontroller.go	59.45%	10 Missing and 5 partials ⚠️
pkg/apis/application/v1alpha1/app_project_types.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21367      +/-   ##
==========================================
+ Coverage   55.25%   55.29%   +0.03%     
==========================================
  Files         337      337              
  Lines       56940    56979      +39     
==========================================
+ Hits        31461    31505      +44     
+ Misses      22801    22799       -2     
+ Partials     2678     2675       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nitishfy]

Can you fix the failing checks?

[KojoRising]

Hi @nitishfy !! So I'm actually having an issue with one of my tests running into a data race condition. Tried a lot of approaches to fix the issue, but I'm unable to solve it.

Would you or @agaudreault mind taking a look at the test when you get a chance? It'd be much appreciated. Thanks!!

[agaudreault]

I am not able to visualize what the code is doing at this point. I think this kind of scenario would benefit from a E2E test. The current unit test are also hard to understand.