Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Rollout promote action #20509

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

y-rabie
Copy link

@y-rabie y-rabie commented Oct 23, 2024

This adds a promote action to the Rollout resource, same as in the Rollouts dashboard. This promotes one step unlike the promote-full action. It also works on promoting while at analysis steps and inconclusive analysis steps unlike the current resume action, which only works if we are at a pause step.

The logic in the action is identical to the way it is implemented in the argo-rollouts plugin.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@y-rabie y-rabie requested a review from a team as a code owner October 23, 2024 16:48
Copy link

bunnyshell bot commented Oct 23, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@agaudreault agaudreault requested a review from zachaller October 30, 2024 16:57
end

if obj.spec.paused ~= nil and obj.spec.paused then
obj.spec.paused = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give more insight on when paused would be true and why do we need to handle it in promote?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pause is set to true only when manually paused by the user, using the kubectl plugin. In the plugin or the rollouts UI however, the un-pause is handled as well in the promote action, and there is no other available action to only unpause a 'manual' pause.

So, it's a semantic difference, where we can handle that in the promote action as well, or leave this bit handled in the resume action only. For the sake of consistency across UIs and plugins however, I feel like this should be handled here. resume action might not be needed anymore

@agaudreault agaudreault enabled auto-merge (squash) November 12, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants