-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Rollout promote action #20509
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Youssef Rabie <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
end | ||
|
||
if obj.spec.paused ~= nil and obj.spec.paused then | ||
obj.spec.paused = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give more insight on when paused would be true and why do we need to handle it in promote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pause is set to true only when manually paused by the user, using the kubectl plugin. In the plugin or the rollouts UI however, the un-pause is handled as well in the promote action, and there is no other available action to only unpause a 'manual' pause.
So, it's a semantic difference, where we can handle that in the promote action as well, or leave this bit handled in the resume
action only. For the sake of consistency across UIs and plugins however, I feel like this should be handled here. resume
action might not be needed anymore
This adds a
promote
action to the Rollout resource, same as in the Rollouts dashboard. This promotes one step unlike thepromote-full
action. It also works on promoting while at analysis steps and inconclusive analysis steps unlike the currentresume
action, which only works if we are at a pause step.The logic in the action is identical to the way it is implemented in the argo-rollouts plugin.
Checklist: