Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datarace config read/write by multiple go routines #1011

Closed
wants to merge 22 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
aff40ab
WIP: print to understand
dido18 Jan 10, 2025
bae632a
refactor: remove unused Bufferflow implementations and simplify buffe…
dido18 Jan 10, 2025
818f79f
refactor: simplify serial test functions by removing unused parameters
dido18 Jan 10, 2025
baf2ff4
fix(ci): update package installation command to use correct version o…
dido18 Jan 10, 2025
e63527a
fix(ci): update libwebkit2gtk version in dependency installation
dido18 Jan 10, 2025
98b6376
fix: remove unused buffer slice and simplify data reading in serial port
dido18 Jan 10, 2025
0ce39a5
small changes
dido18 Jan 10, 2025
ec5049d
fix: remove debug print statement from wsHandler function
dido18 Jan 13, 2025
2fe3c28
fix: add warning log for unexpected arguments in open command
dido18 Jan 13, 2025
1849a1c
Update hub.go
dido18 Jan 13, 2025
294de02
fix: update log message for buffer flow initialization
dido18 Jan 14, 2025
99a31e6
fix: update log message for clarity in buffer flow initialization
dido18 Jan 14, 2025
2308b5f
fix: ignore all tags in check-certificates workflow on push
dido18 Jan 14, 2025
8688ec6
fix: update macOS-13 version in publish-go-tester-task workflow
dido18 Jan 14, 2025
894c139
fix(release): add Go installation step in release workflow
dido18 Jan 14, 2025
3a34186
fix: correct JSON formatting in broadcast message for port registration
dido18 Jan 16, 2025
62e324b
Merge branch 'main' into remove-open-not-used-buffer-algorithm
dido18 Jan 17, 2025
92e9536
fix
dido18 Jan 20, 2025
c042f10
fix: update application identity in release workflow to use Massimo B…
dido18 Jan 20, 2025
34d4452
Merge branch 'main' of github.com:arduino/arduino-create-agent into main
dido18 Jan 21, 2025
9d2b0ab
Merge branch 'main' into remove-open-not-used-buffer-algorithm
dido18 Jan 21, 2025
0587f2b
fix
dido18 Jan 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update macOS-13 version in publish-go-tester-task workflow
dido18 committed Jan 14, 2025
commit 8688ec627d7b82bf94906ca239247e21399995d0
2 changes: 1 addition & 1 deletion .github/workflows/publish-go-tester-task.yml
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@ jobs:
#use the strategy instead because we still use the native build
strategy:
matrix:
os: [ubuntu-20.04, windows-2019, macos-12]
os: [ubuntu-20.04, windows-2019, macos-13]
arch: [-amd64]
include:
- os: windows-2019
18 changes: 9 additions & 9 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ jobs:
prerelease: ${{ steps.prerelease.outputs.IS_PRE }}
strategy:
matrix:
os: [ubuntu-20.04, windows-2019, macos-12]
os: [ubuntu-20.04, windows-2019, macos-13]
arch: [amd64]
include:
- os: windows-2019
@@ -116,7 +116,7 @@ jobs:
run: |
task go:build
mv ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_amd64
if: matrix.os == 'macos-12'
if: matrix.os == 'macos-13'

- name: Build the Agent for macos arm64
env:
@@ -128,13 +128,13 @@ jobs:
run: |
task go:build
mv ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_arm64
if: matrix.os == 'macos-12'
if: matrix.os == 'macos-13'

- name: Create universal macos executable
run: |
lipo -create -output ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_amd64 ${{ env.PROJECT_NAME }}_arm64
rm ${{ env.PROJECT_NAME }}_amd64 ${{ env.PROJECT_NAME }}_arm64
if: matrix.os == 'macos-12'
if: matrix.os == 'macos-13'

# this will create `public/` dir with compressed full bin (<version>/<os>-<arch>.gz) and a json file
- name: Create autoupdate files
@@ -146,7 +146,7 @@ jobs:
run: |
cp darwin-amd64.json darwin-arm64.json
cp ${TAG_VERSION}/darwin-amd64.gz ${TAG_VERSION}/darwin-arm64.gz
if: matrix.os == 'macos-12' && steps.prerelease.outputs.IS_PRE != 'true'
if: matrix.os == 'macos-13' && steps.prerelease.outputs.IS_PRE != 'true'

- name: Create autoupdate files for win32
run: go-selfupdate -platform windows-${{ matrix.arch }} ${{ env.PROJECT_NAME }}${{ matrix.ext }} ${TAG_VERSION}
@@ -181,7 +181,7 @@ jobs:
matrix:
arch: [amd64, arm64]

runs-on: macos-12
runs-on: macos-13
env:
EXE_PATH: "skel/ArduinoCloudAgent.app/Contents/MacOS/"

@@ -195,7 +195,7 @@ jobs:
- name: Download artifact
uses: actions/download-artifact@v4
with:
name: ${{ env.PROJECT_NAME }}-macos-12-amd64 # if we want to support darwin-arm64 in the future for real this has to change.
name: ${{ env.PROJECT_NAME }}-macos-13-amd64 # if we want to support darwin-arm64 in the future for real this has to change.
path: ${{ env.EXE_PATH }}

- name: Remove placeholder file
@@ -252,7 +252,7 @@ jobs:
matrix:
arch: [amd64, arm64]

runs-on: macos-12
runs-on: macos-13
env:
GON_PATH: ${{ github.workspace }}/gon
needs: [build, create-macos-bundle]
@@ -509,7 +509,7 @@ jobs:
matrix:
arch: [amd64]

runs-on: macos-12
runs-on: macos-13
steps:
- name: Checkout repo with icons/background
uses: actions/checkout@v4