-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent word wrapping when badge or trailing icon is (not) present #253
Prevent word wrapping when badge or trailing icon is (not) present #253
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uh oh! @ernstmul, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...What happens when the text is too long?
Uh oh! @ernstmul, the image you shared is missing helpful alt text. Check #253 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
What does this PR do?
ActionMenu Anchor and Button don't take up full available space when no icon or badge is present. And if the icon or badge is present, they take up the width 50/50 with the text (making the text wrap in most cases). This PR fixes that.
ActionMenu.Item.Button before:
ActionMenu.Item.Button after:
ActionMenu.Item.Anchor before:
ActionMenu.Item.Anchor after:
Have you read the Contributing Guidelines on issues?
Yes