-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android support #244
Android support #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcprux the formatter is unhappy but otherwise this looks great
Is there any indication of what it doesn't like? The action log at https://github.com/apple/swift-nio-extras/actions/runs/12766669331/job/35592455040?pr=244 just reports a failure without any diagnostic message. |
It wants you to apply this diff:
|
Done in 63cf347 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks!
Add Android support
Motivation:
Support the Android platform.
Modifications:
Add Android imports and fix the default temporary directory to be correct for the OS.
Result:
The package will build and test on Android.